[GitHub] [superset] geido commented on a diff in pull request #23811: fix: Hide FiltersPanel in standalone mode 3

["geido (via GitHub)" <gi...@apache.org>]

geido commented on code in PR #23811:
URL: https://github.com/apache/superset/pull/23811#discussion_r1176781952


##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -654,6 +655,7 @@ const DashboardBuilder: FC<DashboardBuilderProps> = () => {
               return (
                 <FiltersPanel
                   width={filterBarWidth}
+                  hidden={isReport}

Review Comment:
   The prop itself it is still required for the component as it can be included directly like is the case of the horizontal FilterBar. In this specific case, as the wrapper is hidden too, it's not necessary to pass it to the FilterBar too most probably but I think there is no harm in having it there either



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org