You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/24 08:18:44 UTC

[GitHub] [flink] zhuzhurk opened a new pull request #9754: [FLINK-14182][core] Make TimeUtils able to parse duration string with plural form labels

zhuzhurk opened a new pull request #9754: [FLINK-14182][core] Make TimeUtils able to parse duration string with plural form labels
URL: https://github.com/apache/flink/pull/9754
 
 
   
   ## What is the purpose of the change
   
   
   Scala Duration supports parsing plural form time unit label except for the shortest label of a TimeUnit. Namely:
   { 
     "d day days", 
     "h hour s", 
     "min minute minutes", 
     "s sec secs second seconds", 
     "ms milli millis millisecond milliseconds", 
     "µs micro micros microsecond microseconds", 
     "ns nano nanos nanosecond nanoseconds"
   }
   
   TimeUtils should support them as well.
   
   ## Brief change log
   
     - *Each label now can be marked as singular or plural for a time unit*
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
     - *Unit tests in TimeUtilsTest*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services