You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2012/02/28 21:30:12 UTC

DO NOT REPLY [Bug 52792] New: Incomplete error message when lookup a resource that is not bound in the naming

https://issues.apache.org/bugzilla/show_bug.cgi?id=52792

             Bug #: 52792
           Summary: Incomplete error message when lookup a resource that
                    is not bound in the naming
           Product: Tomcat 7
           Version: 7.0.26
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: Catalina
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: violetagg@apache.org
    Classification: Unclassified


Created attachment 28401
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28401
Patch proposal

Hi,

I have a servlet that specifies @Resource on a field level. (see attached
sample application)
When a request comes for this servlet, Tomcat tries to inject this resource and
to instantiate the servlet. If the resource is not found, 500 ISE is returned
as a response code. In the error message returned in the error page, it is not
specified the full composite name that Tomcat tries to lookup, but only the
first part (the context) (see incorrect.png). Thus the end user cannot
understand which is the resource that causes the problem, but only the context
that cannot be found.

I would like to propose a patch (attached). A screenshot (correct.png) with
corrected error message is also attached.

Thanks in advance.
Regards,
Violeta Georgieva

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 52792] Incomplete error message when lookup a resource that is not bound in the naming

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52792

--- Comment #2 from violetagg@apache.org 2012-02-28 20:32:34 UTC ---
Created attachment 28403
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28403
Correct behaviour

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 52792] Incomplete error message when lookup a resource that is not bound in the naming

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52792

--- Comment #3 from violetagg@apache.org 2012-02-28 20:35:36 UTC ---
Created attachment 28404
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28404
sample application

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 52792] Incomplete error message when lookup a resource that is not bound in the naming

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52792

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Mark Thomas <ma...@apache.org> 2012-03-07 21:14:23 UTC ---
Fixed in trunk and 7.0.x and will be included in 7.0.27 onwards.

There were multiple places where this could occur so i fixed them all. I also
modified the error message to show the full JNDI name that can't be found as
well as the the part that could not be found.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 52792] Incomplete error message when lookup a resource that is not bound in the naming

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52792

--- Comment #1 from violetagg@apache.org 2012-02-28 20:32:03 UTC ---
Created attachment 28402
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28402
Incorrect behaviour

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 52792] Incomplete error message when lookup a resource that is not bound in the naming

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52792

violetagg@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28401|0                           |1
           is patch|                            |
  Attachment #28401|application/octet-stream    |text/plain
          mime type|                            |

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 52792] Incomplete error message when lookup a resource that is not bound in the naming

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52792

--- Comment #5 from violetagg@apache.org 2012-03-08 06:34:46 UTC ---
Great.
Thanks

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org