[GitHub] [tvm] tkonolige commented on a diff in pull request #11066: [PROFILER] Theoretical roofline models

[GitBox <gi...@apache.org>]

tkonolige commented on code in PR #11066:
URL: https://github.com/apache/tvm/pull/11066#discussion_r853527343


##########
python/tvm/analysis/__init__.py:
##########
@@ -0,0 +1,296 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""High level analysis functions"""

Review Comment:
   I wasn't sure about the correct namespace either. It doesn't really fit in `tir` or `relay` because it is about high level features, not anything specific to tir or relay. It doesn't fit in `runtime` because it requires auto scheduler, so I can't put it in `runtime/profiling`. Also, it is not really profiling, it is an analysis.
   
   I don't think `contrib/roofline` is a good match because contrib is poorly defined and adds no extra information. `roofline` doesn't make sense because there are more functions than just the roofline model (estimated flops and bandwidth).
   
   The reason I choose `analysis` is because it seemed better than all the choices listed above. Do you have a reason not to use `analysis`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org