You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "igor-borisoglebski (via GitHub)" <gi...@apache.org> on 2023/02/28 18:54:26 UTC
[GitHub] [apisix-helm-chart] igor-borisoglebski opened a new pull request, #490: bugfix: 0.0.0.0/0 is always set for allow_admin
igor-borisoglebski opened a new pull request, #490:
URL: https://github.com/apache/apisix-helm-chart/pull/490
0.0.0.0/0 is always set for allow_admin. If this is intentional, I suggest this PR is dismissed, but that the documentation is updated registering that fact as it is misleading in its current form
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] igor-borisoglebski commented on pull request #490: bugfix: 0.0.0.0/0 is always set for allow_admin
Posted by "igor-borisoglebski (via GitHub)" <gi...@apache.org>.
igor-borisoglebski commented on PR #490:
URL: https://github.com/apache/apisix-helm-chart/pull/490#issuecomment-1449503002
I've tested that the ingress comes up even when 0.0.0.0/0 is not set. The reason it does is because ingress checks if the port is listening with netcat - which succeeds - even though the API access is not allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 closed pull request #490: bugfix: 0.0.0.0/0 is always set for allow_admin
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 closed pull request #490: bugfix: 0.0.0.0/0 is always set for allow_admin
URL: https://github.com/apache/apisix-helm-chart/pull/490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #490: bugfix: 0.0.0.0/0 is always set for allow_admin
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on PR #490:
URL: https://github.com/apache/apisix-helm-chart/pull/490#issuecomment-1457643071
This is by design. The ingress controller needs to access the Admin API.
This is convenient for most users.
But if you need a more secure configuration, you can modify it yourself, or add NetworkPolicy to control it.
I will close this one since we're not going to tweak it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on pull request #490: bugfix: 0.0.0.0/0 is always set for allow_admin
Posted by "tokers (via GitHub)" <gi...@apache.org>.
tokers commented on PR #490:
URL: https://github.com/apache/apisix-helm-chart/pull/490#issuecomment-1449182224
@igor-borisoglebski This is intentional for convenience, or you have to configure the IP address of the dashboard or ingress controller on the APISIX, which means you need to deploy the ingress controller or dashboard before APISIX. While they before they run, they need to wait until APISIX is ready.
That's the chicken and egg's situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org