You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by jablko <gi...@git.apache.org> on 2014/02/05 21:17:21 UTC
trafficserver pull request: TS-2553 Fix a segfault in the Metalink plugin r...
GitHub user jablko opened a pull request:
https://github.com/apache/trafficserver/pull/38
TS-2553 Fix a segfault in the Metalink plugin reported by Faysal Banna and preserve the Content-Length header
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jablko/trafficserver master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/38.patch
----
commit 21e67b8c574dbeb68533da7fb7e558fa2e156d18
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-02-05T17:41:55Z
Reorder some functions so related functions are grouped together
commit 8240d6584b016b962bb92a9108a82d38b27330ce
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-02-05T17:53:02Z
Rename some variables to more easily disambiguate them
commit 07e418dd884a32a9b7313a38664be1161583ed07
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-02-05T18:07:44Z
Copy the upstream nbytes (if known) downstream to preserve the "Content-Length: ..." header. In that case there will be a TS_EVENT_VCONN_WRITE_COMPLETE event from downstream before ntodo is zero, so write the digest to the cache in transform_vconn_write_complete(). If the upstream nbytes isn't known until the end of the content, update the downstream nbytes and reenable it to get it to send a TS_EVENT_VCONN_WRITE_COMPLETE event. Fix some memory management.
commit 4b2a7ddd8d6603361199daaa0e7f20e7127205ae
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-02-05T18:16:59Z
Avoid segfault in TSVIOReenable() if the client disconnected
commit 4f736761fa939f9ec376f225e37a81f6cd8b4b0d
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-02-05T18:18:54Z
Drop TSVIOBufferGet() and test TSVIOReaderGet() instead
commit d43b8018f3d036bcb0f4b7cdb8beaf06e0ae8103
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-02-05T18:19:52Z
I don't know what this does
commit 85697757ff54f702351b990f84c9669bf19cc5c7
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-02-05T19:01:40Z
Improve comments
commit 274a45f13d11c52374f692222cdaf8f9aa3635db
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-02-05T19:06:50Z
Minor edits
commit 943364c2ba60026a7b289091deb5960ef6097580
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2014-02-05T20:08:30Z
TS-2553 CHANGES
----
Re: trafficserver pull request: TS-2553 Fix a segfault in the Metalink
plugin r...
Posted by James Peach <jp...@apache.org>.
On Feb 5, 2014, at 12:17 PM, jablko <gi...@git.apache.org> wrote:
> GitHub user jablko opened a pull request:
>
> https://github.com/apache/trafficserver/pull/38
>
> TS-2553 Fix a segfault in the Metalink plugin reported by Faysal Banna and preserve the Content-Length header
>
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/jablko/trafficserver master
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/trafficserver/pull/38.patch
Pulled, thanks Jack.
BTW the metalink plugin has public documentation in the file doc/reference/plugins/metafilter.en.rst. Apparently I was confused when I copied the docs across :-/
>
> ----
> commit 21e67b8c574dbeb68533da7fb7e558fa2e156d18
> Author: Jack Bates <ja...@nottheoilrig.com>
> Date: 2014-02-05T17:41:55Z
>
> Reorder some functions so related functions are grouped together
>
> commit 8240d6584b016b962bb92a9108a82d38b27330ce
> Author: Jack Bates <ja...@nottheoilrig.com>
> Date: 2014-02-05T17:53:02Z
>
> Rename some variables to more easily disambiguate them
>
> commit 07e418dd884a32a9b7313a38664be1161583ed07
> Author: Jack Bates <ja...@nottheoilrig.com>
> Date: 2014-02-05T18:07:44Z
>
> Copy the upstream nbytes (if known) downstream to preserve the "Content-Length: ..." header. In that case there will be a TS_EVENT_VCONN_WRITE_COMPLETE event from downstream before ntodo is zero, so write the digest to the cache in transform_vconn_write_complete(). If the upstream nbytes isn't known until the end of the content, update the downstream nbytes and reenable it to get it to send a TS_EVENT_VCONN_WRITE_COMPLETE event. Fix some memory management.
>
> commit 4b2a7ddd8d6603361199daaa0e7f20e7127205ae
> Author: Jack Bates <ja...@nottheoilrig.com>
> Date: 2014-02-05T18:16:59Z
>
> Avoid segfault in TSVIOReenable() if the client disconnected
>
> commit 4f736761fa939f9ec376f225e37a81f6cd8b4b0d
> Author: Jack Bates <ja...@nottheoilrig.com>
> Date: 2014-02-05T18:18:54Z
>
> Drop TSVIOBufferGet() and test TSVIOReaderGet() instead
>
> commit d43b8018f3d036bcb0f4b7cdb8beaf06e0ae8103
> Author: Jack Bates <ja...@nottheoilrig.com>
> Date: 2014-02-05T18:19:52Z
>
> I don't know what this does
>
> commit 85697757ff54f702351b990f84c9669bf19cc5c7
> Author: Jack Bates <ja...@nottheoilrig.com>
> Date: 2014-02-05T19:01:40Z
>
> Improve comments
>
> commit 274a45f13d11c52374f692222cdaf8f9aa3635db
> Author: Jack Bates <ja...@nottheoilrig.com>
> Date: 2014-02-05T19:06:50Z
>
> Minor edits
>
> commit 943364c2ba60026a7b289091deb5960ef6097580
> Author: Jack Bates <ja...@nottheoilrig.com>
> Date: 2014-02-05T20:08:30Z
>
> TS-2553 CHANGES
>
> ----
>