You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/06/18 23:01:51 UTC

Review Request 22757: Exposed MessageEvent queue size from Master/Scheduler.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22757/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Bugs: MESOS-1510
    https://issues.apache.org/jira/browse/MESOS-1510


Repository: mesos-git


Description
-------

see summary


Diffs
-----

  src/master/master.hpp 2844446e2674df6e11f4c2915ed324fcc103532c 
  src/master/master.cpp 888657dd4bc50085882382908e3c48ccb857c621 
  src/sched/sched.cpp a82a39d9fd713fe17a0bc84675f0562ea7564869 
  src/tests/master_tests.cpp a60709faf3a13994aebf1286d41832901fe38ea8 
  src/tests/scheduler_tests.cpp 5cc6b264e2c3de241ebd001bf22828423c03a51e 

Diff: https://reviews.apache.org/r/22757/diff/


Testing
-------

make check


Thanks,

Dominic Hamon


Re: Review Request 22757: Exposed MessageEvent queue size from Master/Scheduler.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22757/#review46244
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On June 18, 2014, 9:01 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22757/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 9:01 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1510
>     https://issues.apache.org/jira/browse/MESOS-1510
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 2844446e2674df6e11f4c2915ed324fcc103532c 
>   src/master/master.cpp 888657dd4bc50085882382908e3c48ccb857c621 
>   src/sched/sched.cpp a82a39d9fd713fe17a0bc84675f0562ea7564869 
>   src/tests/master_tests.cpp a60709faf3a13994aebf1286d41832901fe38ea8 
>   src/tests/scheduler_tests.cpp 5cc6b264e2c3de241ebd001bf22828423c03a51e 
> 
> Diff: https://reviews.apache.org/r/22757/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 22757: Exposed MessageEvent queue size from Master/Scheduler.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22757/#review46186
-----------------------------------------------------------


Patch looks great!

Reviews applied: [22756, 22757]

All tests passed.

- Mesos ReviewBot


On June 18, 2014, 9:01 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22757/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 9:01 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1510
>     https://issues.apache.org/jira/browse/MESOS-1510
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 2844446e2674df6e11f4c2915ed324fcc103532c 
>   src/master/master.cpp 888657dd4bc50085882382908e3c48ccb857c621 
>   src/sched/sched.cpp a82a39d9fd713fe17a0bc84675f0562ea7564869 
>   src/tests/master_tests.cpp a60709faf3a13994aebf1286d41832901fe38ea8 
>   src/tests/scheduler_tests.cpp 5cc6b264e2c3de241ebd001bf22828423c03a51e 
> 
> Diff: https://reviews.apache.org/r/22757/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>