You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/07/21 10:00:23 UTC
[GitHub] [tomcat] stokito commented on a change in pull request #316: Use lowercase HTML tags and attributes. Add quotes around attributes.
stokito commented on a change in pull request #316:
URL: https://github.com/apache/tomcat/pull/316#discussion_r457980335
##########
File path: webapps/ROOT/index.jsp
##########
@@ -25,11 +25,11 @@ request.setAttribute("tomcatExamplesUrl", "/examples/");
<!DOCTYPE html>
<html lang="en">
<head>
- <meta charset="UTF-8" />
+ <meta charset="UTF-8">
<title><%=request.getServletContext().getServerInfo() %></title>
- <link href="favicon.ico" rel="icon" type="image/x-icon" />
- <link href="favicon.ico" rel="shortcut icon" type="image/x-icon" />
- <link href="tomcat.css" rel="stylesheet" type="text/css" />
+ <link href="favicon.ico" rel="icon" type="image/x-icon">
Review comment:
in fact we can remove the line but the favicon.ico will be anyway requested by a browser. The tag makes sense when the file name is another
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org