You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "DomGarguilo (via GitHub)" <gi...@apache.org> on 2025/08/01 19:07:39 UTC
[PR] Fix TestAmple shared writer overrides [accumulo]
DomGarguilo opened a new pull request, #5774:
URL: https://github.com/apache/accumulo/pull/5774
Changes made in #5763 added shared ConditionalWriters for ample. This PR fixes the related methods in TestAmple.
Several ITs were broken including TestAmpleIT_SimpleSuite, UserFateStoreFateIT_SimpleSuite, multiple other tests in SimpleSharedMacTestSuiteIT. These should all be fixed now with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix TestAmple shared writer overrides [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on code in PR #5774:
URL: https://github.com/apache/accumulo/pull/5774#discussion_r2252035544
##########
test/src/main/java/org/apache/accumulo/test/ample/metadata/TestAmple.java:
##########
@@ -258,6 +258,32 @@ public ServiceLock getServiceLock() {
public void setServiceLock(ServiceLock lock) {
context.setServiceLock(lock);
}
+
+ @Override
+ public java.util.function.Supplier<ConditionalWriter> getSharedMetadataWriter() {
+ return () -> {
Review Comment:
Yea good idea. Added in 4bbafd2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix TestAmple shared writer overrides [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #5774:
URL: https://github.com/apache/accumulo/pull/5774#discussion_r2248864357
##########
test/src/main/java/org/apache/accumulo/test/ample/metadata/TestAmple.java:
##########
@@ -258,6 +258,32 @@ public ServiceLock getServiceLock() {
public void setServiceLock(ServiceLock lock) {
context.setServiceLock(lock);
}
+
+ @Override
+ public java.util.function.Supplier<ConditionalWriter> getSharedMetadataWriter() {
+ return () -> {
Review Comment:
Can these suppliers be memoized? That would make the behavior of test ample more similar to the real ample. Seems like this is always creating new conditional writers. If it can be memoized it would make the behavior of test ample more similar to the real ample.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix TestAmple shared writer overrides [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo merged PR #5774:
URL: https://github.com/apache/accumulo/pull/5774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org