You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@apache.org on 2007/12/01 02:34:30 UTC

svn commit: r600030 - /httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c

Author: wrowe
Date: Fri Nov 30 17:34:29 2007
New Revision: 600030

URL: http://svn.apache.org/viewvc?rev=600030&view=rev
Log:
Reading RFC2428 gives us no clue if case insensitivity is
intended for the "EPSV ALL" command.  But binding to RFC959,
it's clear the case of EPSV is case insensitive, and RFC2428
doesn't illustrate this, either, so presume that "epsv all"
would also be acceptable and not ambiguous.


Modified:
    httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c

Modified: httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c
URL: http://svn.apache.org/viewvc/httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c?rev=600030&r1=600029&r2=600030&view=diff
==============================================================================
--- httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c (original)
+++ httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c Fri Nov 30 17:34:29 2007
@@ -1489,7 +1489,7 @@
     const char *addr;
     int family = 0;
 
-    if (strcmp(arg, "ALL") == 0) {
+    if (strcasecmp(arg, "ALL") == 0) {
         /* A contract to never respond to other data connection methods */
         fc->all_epsv = 1;
         fc->response_notes = apr_psprintf(r->pool, FTP_MSG_SUCCESS, r->method);