You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/12 20:00:35 UTC
[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #4132: serial: add ctrl+@ to force crash system for debugging
GUIDINGLI opened a new pull request #4132:
URL: https://github.com/apache/incubator-nuttx/pull/4132
## Summary
serial: add ctrl+@ to force crash system for debugging
For debugging system, sometime shell blocked (dealock or busyloop), then we want see all the thread running location,
then we can force crash the system
So there is the patch, force crash the system & get dump log by check one specific CHAR in uart irq handler.
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #4132: serial: add ctrl+@ to force crash system for debugging
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #4132:
URL: https://github.com/apache/incubator-nuttx/pull/4132#discussion_r668174648
##########
File path: drivers/serial/Kconfig
##########
@@ -173,6 +173,20 @@ config SERIAL_TERMIOS
If this is not defined, then the terminal settings (baud, parity, etc).
are not configurable at runtime; serial streams cannot be flushed, etc..
+config TTY_FORCE_PANIC
Review comment:
Yes, I agree! If it is used in production (final product) it should be used to get more information to hack the system. I used similar approach in the past to gather more information from a Sony TV running Linux: https://acassis.wordpress.com/2014/10/08/more-sony-kdl-32ex405-logs/
We want NuttX to be harder to hack!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #4132: serial: add ctrl+@ to force crash system for debugging
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #4132:
URL: https://github.com/apache/incubator-nuttx/pull/4132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4132: serial: add ctrl+@ to force crash system for debugging
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4132:
URL: https://github.com/apache/incubator-nuttx/pull/4132#discussion_r667948943
##########
File path: drivers/serial/Kconfig
##########
@@ -173,6 +173,20 @@ config SERIAL_TERMIOS
If this is not defined, then the terminal settings (baud, parity, etc).
are not configurable at runtime; serial streams cannot be flushed, etc..
+config TTY_FORCE_PANIC
Review comment:
I think it is more appropriate to add these options below `CONFIG_DEBUG_FEATURES`, in a new option "Serial Debug Features".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] GUIDINGLI commented on a change in pull request #4132: serial: add ctrl+@ to force crash system for debugging
Posted by GitBox <gi...@apache.org>.
GUIDINGLI commented on a change in pull request #4132:
URL: https://github.com/apache/incubator-nuttx/pull/4132#discussion_r668873364
##########
File path: drivers/serial/Kconfig
##########
@@ -173,6 +173,20 @@ config SERIAL_TERMIOS
If this is not defined, then the terminal settings (baud, parity, etc).
are not configurable at runtime; serial streams cannot be flushed, etc..
+config TTY_FORCE_PANIC
Review comment:
Good suggestion, and many thanks, TTY_FORCE_PANIC depends on DEBUG_FEATURES.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #4132: serial: add ctrl+@ to force crash system for debugging
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #4132:
URL: https://github.com/apache/incubator-nuttx/pull/4132#discussion_r668174648
##########
File path: drivers/serial/Kconfig
##########
@@ -173,6 +173,20 @@ config SERIAL_TERMIOS
If this is not defined, then the terminal settings (baud, parity, etc).
are not configurable at runtime; serial streams cannot be flushed, etc..
+config TTY_FORCE_PANIC
Review comment:
Yes, I agree! If it is used in production (final product) it could be used to get more information to hack the system. I used similar approach in the past to gather more information from a Sony TV running Linux: https://acassis.wordpress.com/2014/10/08/more-sony-kdl-32ex405-logs/
We want NuttX to be harder to hack!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org