You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2015/02/14 03:21:18 UTC
Review Request 31041: HIVE-9645 : Fold expressions involving null
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31041/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-9645
https://issues.apache.org/jira/browse/HIVE-9645
Repository: hive-git
Description
-------
Fold expressions involving null
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java 79a6181
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java c596883
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFArray.java 55a47fb
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDecode.java 9858b4f
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLastDay.java 3a43c57
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMap.java 4234b76
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNextDay.java 38f08b7
ql/src/test/queries/clientpositive/optimize_nullscan.q 8e2ae04
ql/src/test/queries/clientpositive/orc_vectorization_ppd.q 9bdad86
ql/src/test/results/clientpositive/decimal_udf.q.out fbf4208
ql/src/test/results/clientpositive/input8.q.out 47bac2c
ql/src/test/results/clientpositive/input9.q.out 4666787
ql/src/test/results/clientpositive/load_dyn_part14.q.out e5fe51f
ql/src/test/results/clientpositive/num_op_type_conv.q.out 708fb51
ql/src/test/results/clientpositive/optimize_nullscan.q.out 609e415
ql/src/test/results/clientpositive/ppd_constant_expr.q.out 56813e4
ql/src/test/results/clientpositive/spark/auto_join8.q.out 5b6cc80
ql/src/test/results/clientpositive/spark/join8.q.out dcfbc3d
ql/src/test/results/clientpositive/spark/load_dyn_part14.q.out 66db7bd
ql/src/test/results/clientpositive/spark/optimize_nullscan.q.out 881f41a
ql/src/test/results/clientpositive/tez/optimize_nullscan.q.out 104654a
ql/src/test/results/clientpositive/tez/vector_coalesce.q.out 2f7eb43
ql/src/test/results/clientpositive/tez/vector_decimal_udf.q.out 8e7371a
ql/src/test/results/clientpositive/udf6.q.out 1de47ab
ql/src/test/results/clientpositive/udf_case.q.out ed0aac0
ql/src/test/results/clientpositive/udf_coalesce.q.out 322dc4e
ql/src/test/results/clientpositive/udf_elt.q.out f8acbf2
ql/src/test/results/clientpositive/udf_greatest.q.out 884095b
ql/src/test/results/clientpositive/udf_if.q.out a2d2c08
ql/src/test/results/clientpositive/udf_instr.q.out 812f244
ql/src/test/results/clientpositive/udf_isnull_isnotnull.q.out a7d45ea
ql/src/test/results/clientpositive/udf_least.q.out 95e3467
ql/src/test/results/clientpositive/udf_locate.q.out 1d10ecd
ql/src/test/results/clientpositive/udf_nvl.q.out 5042577
ql/src/test/results/clientpositive/udf_size.q.out 95b8e61
ql/src/test/results/clientpositive/udf_when.q.out 52f15b3
ql/src/test/results/clientpositive/vector_coalesce.q.out 096ee22
ql/src/test/results/clientpositive/vector_decimal_udf.q.out 102fd07
Diff: https://reviews.apache.org/r/31041/diff/
Testing
-------
Existing tests and also added a new test.
Thanks,
Ashutosh Chauhan
Re: Review Request 31041: HIVE-9645 : Fold expressions involving null
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31041/
-----------------------------------------------------------
(Updated April 10, 2015, 11:09 p.m.)
Review request for hive.
Changes
-------
Preserves type of folded null-constant.
Bugs: HIVE-9645
https://issues.apache.org/jira/browse/HIVE-9645
Repository: hive-git
Description
-------
Fold expressions involving null
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 14a1059
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ConstantVectorExpression.java c76b15b
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java b0768f2
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java d18e1a7
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java 513d030
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java 4cf6318
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFArray.java 55a47fb
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCbrt.java 732ce8a
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDecode.java 9858b4f
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFactorial.java ff63b1d
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLastDay.java 6ead4be
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLevenshtein.java 4bba876
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMap.java 4234b76
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNextDay.java c0a0ab1
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSoundex.java ad72d05
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrunc.java 3bf8d34
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLevenshtein.java 9f14ffd
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFNextDay.java 83ded3c
ql/src/test/queries/clientpositive/optimize_nullscan.q 8e2ae04
ql/src/test/results/clientnegative/udf_add_months_error_1.q.out e128612
ql/src/test/results/clientnegative/udf_last_day_error_1.q.out 71376e2
ql/src/test/results/clientnegative/udf_next_day_error_1.q.out 1d9c25f
ql/src/test/results/clientnegative/udf_next_day_error_2.q.out e23186a
ql/src/test/results/clientpositive/annotate_stats_select.q.out 49c1a40
ql/src/test/results/clientpositive/decimal_udf.q.out 59b5643
ql/src/test/results/clientpositive/input8.q.out 47bac2c
ql/src/test/results/clientpositive/input9.q.out 4666787
ql/src/test/results/clientpositive/load_dyn_part14.q.out ccf6f82
ql/src/test/results/clientpositive/num_op_type_conv.q.out 708fb51
ql/src/test/results/clientpositive/optimize_nullscan.q.out 609e415
ql/src/test/results/clientpositive/ppd_constant_expr.q.out 56813e4
ql/src/test/results/clientpositive/spark/auto_join8.q.out 5b6cc80
ql/src/test/results/clientpositive/spark/join8.q.out dcfbc3d
ql/src/test/results/clientpositive/spark/load_dyn_part14.q.out 66db7bd
ql/src/test/results/clientpositive/spark/optimize_nullscan.q.out 881f41a
ql/src/test/results/clientpositive/spark/vector_elt.q.out 180ea15
ql/src/test/results/clientpositive/tez/optimize_nullscan.q.out 104654a
ql/src/test/results/clientpositive/tez/vector_coalesce.q.out 2f7eb43
ql/src/test/results/clientpositive/tez/vector_decimal_udf.q.out 96f19ac
ql/src/test/results/clientpositive/tez/vector_elt.q.out b27798a
ql/src/test/results/clientpositive/udf4.q.out 1dfd7f8
ql/src/test/results/clientpositive/udf6.q.out 1de47ab
ql/src/test/results/clientpositive/udf7.q.out e616fed
ql/src/test/results/clientpositive/udf_case.q.out ed0aac0
ql/src/test/results/clientpositive/udf_coalesce.q.out 322dc4e
ql/src/test/results/clientpositive/udf_elt.q.out f8acbf2
ql/src/test/results/clientpositive/udf_greatest.q.out 884095b
ql/src/test/results/clientpositive/udf_hour.q.out 4eb5a00
ql/src/test/results/clientpositive/udf_if.q.out a2d2c08
ql/src/test/results/clientpositive/udf_instr.q.out 812f244
ql/src/test/results/clientpositive/udf_isnull_isnotnull.q.out a7d45ea
ql/src/test/results/clientpositive/udf_least.q.out 95e3467
ql/src/test/results/clientpositive/udf_locate.q.out 1d10ecd
ql/src/test/results/clientpositive/udf_minute.q.out ebd07c5
ql/src/test/results/clientpositive/udf_nvl.q.out 5042577
ql/src/test/results/clientpositive/udf_parse_url.q.out f657fa9
ql/src/test/results/clientpositive/udf_second.q.out fcd1143
ql/src/test/results/clientpositive/udf_size.q.out 95b8e61
ql/src/test/results/clientpositive/udf_trunc.q.out b9b2c48
ql/src/test/results/clientpositive/udf_when.q.out 52f15b3
ql/src/test/results/clientpositive/vector_coalesce.q.out 096ee22
ql/src/test/results/clientpositive/vector_decimal_udf.q.out 189e85f
ql/src/test/results/clientpositive/vector_elt.q.out 3a2c1fc
Diff: https://reviews.apache.org/r/31041/diff/
Testing
-------
Existing tests and also added a new test.
Thanks,
Ashutosh Chauhan