[GitHub] rombert commented on issue #5: Feature/stop selector duplication

[GitBox <gi...@apache.org>]

rombert commented on issue #5: Feature/stop selector duplication
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/5#issuecomment-408887166
 
 
   @toniedzwiedz  - thanks for the update. If you look at the generated manifest, you will see that the `urlbuilder` package is still included in the list of exported packages. I would suggest moving it to an `impl` or `internal` package so that it's automatically excluded from the export packages.
   
   Also, the release depends on whether we have other contributions to process, but it should be OK to start the release after the PR is merged, and then the release is available in ~3 days.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services