You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "alanlvle (via GitHub)" <gi...@apache.org> on 2023/07/05 06:48:05 UTC
[GitHub] [skywalking-java] alanlvle opened a new pull request, #570: fix CVE-2023-2976 and CVE-2023-34462
alanlvle opened a new pull request, #570:
URL: https://github.com/apache/skywalking-java/pull/570
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking-java/blob/main/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] alanlvle commented on pull request #570: fix CVE-2023-2976 and CVE-2023-34462
Posted by "alanlvle (via GitHub)" <gi...@apache.org>.
alanlvle commented on PR #570:
URL: https://github.com/apache/skywalking-java/pull/570#issuecomment-1621265807
> All versions in test are not necessary, actually.
I need revert it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] alanlvle commented on a diff in pull request #570: fix CVE-2023-2976 and CVE-2023-34462
Posted by "alanlvle (via GitHub)" <gi...@apache.org>.
alanlvle commented on code in PR #570:
URL: https://github.com/apache/skywalking-java/pull/570#discussion_r1252672354
##########
apm-sniffer/apm-sdk-plugin/guava-eventbus-plugin/pom.xml:
##########
@@ -27,7 +27,7 @@
<artifactId>apm-guava-eventbus-plugin</artifactId>
<properties>
- <guava.version>31.0.1-jre</guava.version>
+ <guava.version>32.0.1-jre</guava.version>
Review Comment:
ok,reducing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #570: fix CVE-2023-2976 and CVE-2023-34462
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #570:
URL: https://github.com/apache/skywalking-java/pull/570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #570: fix CVE-2023-2976 and CVE-2023-34462
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #570:
URL: https://github.com/apache/skywalking-java/pull/570#issuecomment-1621174177
I can't see the guava version update in the license file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #570: fix CVE-2023-2976 and CVE-2023-34462
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #570:
URL: https://github.com/apache/skywalking-java/pull/570#issuecomment-1621131017
You need to update change logs and licenses to adopt these dependencies lib changes.
And tests codes don't matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #570: fix CVE-2023-2976 and CVE-2023-34462
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #570:
URL: https://github.com/apache/skywalking-java/pull/570#issuecomment-1621246663
All versions in test are not necessary, actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] alanlvle commented on pull request #570: fix CVE-2023-2976 and CVE-2023-34462
Posted by "alanlvle (via GitHub)" <gi...@apache.org>.
alanlvle commented on PR #570:
URL: https://github.com/apache/skywalking-java/pull/570#issuecomment-1621139546
update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #570: fix CVE-2023-2976 and CVE-2023-34462
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #570:
URL: https://github.com/apache/skywalking-java/pull/570#issuecomment-1621284487
It's fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] lujiajing1126 commented on a diff in pull request #570: fix CVE-2023-2976 and CVE-2023-34462
Posted by "lujiajing1126 (via GitHub)" <gi...@apache.org>.
lujiajing1126 commented on code in PR #570:
URL: https://github.com/apache/skywalking-java/pull/570#discussion_r1252660449
##########
apm-sniffer/apm-sdk-plugin/guava-eventbus-plugin/pom.xml:
##########
@@ -27,7 +27,7 @@
<artifactId>apm-guava-eventbus-plugin</artifactId>
<properties>
- <guava.version>31.0.1-jre</guava.version>
+ <guava.version>32.0.1-jre</guava.version>
Review Comment:
This is not necessary since it should be a provided dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] lujiajing1126 commented on pull request #570: fix CVE-2023-2976 and CVE-2023-34462
Posted by "lujiajing1126 (via GitHub)" <gi...@apache.org>.
lujiajing1126 commented on PR #570:
URL: https://github.com/apache/skywalking-java/pull/570#issuecomment-1621284199
> > All versions in test are not necessary, actually.
>
> I need revert it?
Sure. Pls only make necessary changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org