You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/11/17 10:19:30 UTC

[GitHub] [netbeans] jpeseknb opened a new pull request #2541: Gradle projects should recognize Kotlin source directories.

jpeseknb opened a new pull request #2541:
URL: https://github.com/apache/netbeans/pull/2541


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #2541: [NETBEANS-5050] Gradle projects should recognize Kotlin source directories.

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2541:
URL: https://github.com/apache/netbeans/pull/2541#issuecomment-731769863


   I'd squash and merge this change however you need to have a public email on your GitHub account.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on pull request #2541: [NETBEANS-5050] Gradle projects should recognize Kotlin source directories.

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2541:
URL: https://github.com/apache/netbeans/pull/2541#issuecomment-732452540


   @lkishalmi I agree with your assessment and would consider this an evolution. Without diminishing the work done here one might argue, that from observing the surrounding source, you could reach the same conclusion/implementation. So @jpeseknb if you intend to contribute more work (certainly appreciated!) I suggest to get an ICLA on file and there is no doubt, if you are unsure, please acknowledge here or in the issue (they are linked and thus a record will be retained with the ASF) that this code proposed here is yours and you understand, that you donate the code to the ASF (as stated in the license header of the files you edited).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] jpeseknb commented on pull request #2541: Gradle projects should recognize Kotlin source directories.

Posted by GitBox <gi...@apache.org>.
jpeseknb commented on pull request #2541:
URL: https://github.com/apache/netbeans/pull/2541#issuecomment-731752434


   @lkishalmi I've filled https://issues.apache.org/jira/browse/NETBEANS-5050 and updated the patch in cfd8de3.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #2541: [NETBEANS-5050] Gradle projects should recognize Kotlin source directories.

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2541:
URL: https://github.com/apache/netbeans/pull/2541#issuecomment-946100725


   Rebased on latest master, seems to work as the attached screenshot shows. Ready to merge (if CI agrees as well).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi merged pull request #2541: [NETBEANS-5050] Gradle projects should recognize Kotlin source directories.

Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2541:
URL: https://github.com/apache/netbeans/pull/2541


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #2541: Gradle projects should recognize Kotlin source directories.

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2541:
URL: https://github.com/apache/netbeans/pull/2541#issuecomment-729338830


   Thanks for your contribution!
   Also a JIRA enhancement issue would be really nice!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #2541: [NETBEANS-5050] Gradle projects should recognize Kotlin source directories.

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2541:
URL: https://github.com/apache/netbeans/pull/2541#issuecomment-731770437


   @matthiasblaesing I think this contribution is a natural extension of the code we already have, however I'd like you have a look. Do we require a signed ICLA in this case?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on a change in pull request #2541: Gradle projects should recognize Kotlin source directories.

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2541:
URL: https://github.com/apache/netbeans/pull/2541#discussion_r525665976



##########
File path: java/gradle.java/src/org/netbeans/modules/gradle/java/api/GradleJavaSourceSet.java
##########
@@ -42,12 +42,13 @@
         "LBL_JAVA=Java",
         "LBL_GROOVY=Groovy",
         "LBL_SCALA=Scala",
+        "LBL_KOTLIN=Kotlin",
         "LBL_RESOURCES=Resources",
         "LBL_GENERATED=Generated"
     })
     public static enum SourceType {
 
-        JAVA, GROOVY, SCALA, RESOURCES,
+        JAVA, GROOVY, SCALA, KOTLIN, RESOURCES,

Review comment:
       Always add enum at the end of the list when extending an API, aslo add javadoce with @since annotation. see GENERATED




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on a change in pull request #2541: Gradle projects should recognize Kotlin source directories.

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2541:
URL: https://github.com/apache/netbeans/pull/2541#discussion_r525672456



##########
File path: extide/gradle/netbeans-gradle-tooling/src/main/groovy/org/netbeans/modules/gradle/tooling/NbProjectInfoBuilder.groovy
##########
@@ -199,12 +199,15 @@ class NbProjectInfoBuilder {
         boolean hasJava = project.plugins.hasPlugin('java-base')
         boolean hasGroovy = project.plugins.hasPlugin('groovy-base')
         boolean hasScala = project.plugins.hasPlugin('scala-base')
+        boolean hasKotlin = project.plugins.hasPlugin('org.jetbrains.kotlin.android') ||

Review comment:
       I'd add these plugins to the detectPlugins (line 140) as well, so it other NetBeans modules can enrich the GradleProject Lookup when they are present.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] ebarboni commented on pull request #2541: [NETBEANS-5050] Gradle projects should recognize Kotlin source directories.

Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2541:
URL: https://github.com/apache/netbeans/pull/2541#issuecomment-884206561


   still no answer changing to milestone 12.6


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] geertjanw commented on pull request #2541: [NETBEANS-5050] Gradle projects should recognize Kotlin source directories.

Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #2541:
URL: https://github.com/apache/netbeans/pull/2541#issuecomment-821066185


   There are conflicts to be resolved here. Changing milestone to 12.5.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] neilcsmith-net commented on pull request #2541: [NETBEANS-5050] Gradle projects should recognize Kotlin source directories.

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2541:
URL: https://github.com/apache/netbeans/pull/2541#issuecomment-766108545


   @lkishalmi moving to 12.4 milestone, but happy for you to retarget back if you think we should and we can get this in by beta2.  We can squash and merge to the PR branch without requiring changes by the author if need be.  And disagree on need for ICLA in this case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists