You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2018/03/28 00:34:33 UTC
[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9836
Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh
......................................................................
IMPALA-6753: Update Hadoop versions in impala-config.sh
Updates from 5.15.0-SNAPSHOT to 5.16.0-SNAPSHOT
Change-Id: I0bbd41484a491990417565ed4dceabd12e29d4c5
---
M bin/impala-config.sh
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/9836/2
--
To view, visit http://gerrit.cloudera.org:8080/9836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bbd41484a491990417565ed4dceabd12e29d4c5
Gerrit-Change-Number: 9836
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 )
Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9836/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9836/2//COMMIT_MSG@10
PS2, Line 10:
> I assume you'll want to mark this not for 2.x.
Done
--
To view, visit http://gerrit.cloudera.org:8080/9836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bbd41484a491990417565ed4dceabd12e29d4c5
Gerrit-Change-Number: 9836
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Mar 2018 00:56:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 )
Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh
......................................................................
Patch Set 3: Code-Review+1
This makes sense as I understand things. Again, if we care about 2.x, I think you'll want to craft a second review for refs/for/2.x that does the equivalent thing there.
--
To view, visit http://gerrit.cloudera.org:8080/9836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bbd41484a491990417565ed4dceabd12e29d4c5
Gerrit-Change-Number: 9836
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Mar 2018 01:00:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 )
Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh
......................................................................
Patch Set 3: Code-Review+2
This looks good to me. Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/9836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bbd41484a491990417565ed4dceabd12e29d4c5
Gerrit-Change-Number: 9836
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Mar 2018 02:08:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 )
Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2194/
--
To view, visit http://gerrit.cloudera.org:8080/9836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bbd41484a491990417565ed4dceabd12e29d4c5
Gerrit-Change-Number: 9836
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Mar 2018 03:57:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9836 )
Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh
......................................................................
IMPALA-6753: Update Hadoop versions in impala-config.sh
Updates from 5.15.0-SNAPSHOT to 5.16.0-SNAPSHOT
Cherry-picks: not for 2.x
Change-Id: I0bbd41484a491990417565ed4dceabd12e29d4c5
Reviewed-on: http://gerrit.cloudera.org:8080/9836
Reviewed-by: Michael Brown <mi...@cloudera.com>
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M bin/impala-config.sh
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Michael Brown: Looks good to me, but someone else must approve
Lars Volker: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0bbd41484a491990417565ed4dceabd12e29d4c5
Gerrit-Change-Number: 9836
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Michael Brown, Philip Zeyliger, Sailesh Mukil, Vuk Ercegovac,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9836
to look at the new patch set (#3).
Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh
......................................................................
IMPALA-6753: Update Hadoop versions in impala-config.sh
Updates from 5.15.0-SNAPSHOT to 5.16.0-SNAPSHOT
Cherry-picks: not for 2.x
Change-Id: I0bbd41484a491990417565ed4dceabd12e29d4c5
---
M bin/impala-config.sh
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/9836/3
--
To view, visit http://gerrit.cloudera.org:8080/9836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0bbd41484a491990417565ed4dceabd12e29d4c5
Gerrit-Change-Number: 9836
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 )
Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bbd41484a491990417565ed4dceabd12e29d4c5
Gerrit-Change-Number: 9836
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Mar 2018 07:49:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 )
Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9836/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9836/2//COMMIT_MSG@10
PS2, Line 10:
I assume you'll want to mark this not for 2.x.
We either don't care enough about 2.x to update this at all, or if we do, this will be conflicted and you'll have to fix conflicts in a separate patch.
--
To view, visit http://gerrit.cloudera.org:8080/9836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bbd41484a491990417565ed4dceabd12e29d4c5
Gerrit-Change-Number: 9836
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Mar 2018 00:45:13 +0000
Gerrit-HasComments: Yes