[GitHub] [druid] gianm commented on pull request #13138: Fix the Injector creation in HadoopTask

[GitBox <gi...@apache.org>]

gianm commented on PR #13138:
URL: https://github.com/apache/druid/pull/13138#issuecomment-1255285420

   Thanks for the fix!
   
   The line you're adjusting is a regression in 24.0.0. From looking at the code, it seems that the impact here is the `index_hadoop` task won't properly realize which extensions are configured (since it isn't reading the server properties files) and therefore won't ship those jars to the Hadoop cluster. I think it would cause problems for jobs that use extensions such as sketches. That's a big enough issue that we should do a 24.0.1 release. So, I created a milestone and added this to it.
   
   About testing: how did test your fix here, and do you know why this wasn't caught as part of the 24.0.0 release testing? We'll want to make sure to test this case for 24.0.1 and future releases, ideally with an automated test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org