[GitHub] [flink] predatorray commented on a change in pull request #16494: [FLINK-22452][Connectors/Kafka] Support specifying custom transactional.id prefix in FlinkKafkaProducer

[GitBox <gi...@apache.org>]

predatorray commented on a change in pull request #16494:
URL: https://github.com/apache/flink/pull/16494#discussion_r670466876



##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
##########
@@ -248,6 +248,9 @@
     /** Flag controlling whether we are writing the Flink record's timestamp into Kafka. */
     protected boolean writeTimestampToKafka = false;
 
+    /** The transactional.id prefix to be used by the producers when communicating with Kafka. */
+    private String transactionalIdPrefix = null;

Review comment:
       Sorry for not following the Code Style and Quality Guide. I'll annotate it with `@Nullable`. Btw, since the parameter of the `setTransactionalId()` method is not annotated with `@Nullable` on #L793, which indicates it is nonnull. Shall I do a `Preconditions.checkNotNull` in the method?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org