[jira] [Commented] (PARQUET-1470) Inputstream leakage in ParquetFileWriter.appendFile

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760198#comment-16760198 ] 

ASF GitHub Bot commented on PARQUET-1470:
-----------------------------------------

Fokko commented on pull request #611: [PARQUET-1470] Inputstream leakage in ParquetFileWriter.appendFile
URL: https://github.com/apache/parquet-mr/pull/611
 
 
   Add a try-with-resource: https://jira.apache.org/jira/browse/PARQUET-1470
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Inputstream leakage in ParquetFileWriter.appendFile
> ---------------------------------------------------
>
>                 Key: PARQUET-1470
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1470
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-mr
>    Affects Versions: 1.10.0
>            Reporter: Arnaud Linz
>            Assignee: Fokko Driesprong
>            Priority: Major
>              Labels: pull-request-available
>
> Current implementation of ParquetFileWriter.appendFile is:
>  
> {{public void appendFile(InputFile file) throws IOException {}}
> {{    ParquetFileReader.open(file).appendTo(this);}}
> {{ }}}
> this method never closes the inputstream created when the file is opened in the ParquetFileReader constructor.
> This leads for instance to TooManyFilesOpened exceptions when large merge are made with the parquet tools.
> something  like
> {{ try (ParquetFileReader reader = ParquetFileReader.open(file)) {}}
> {{    reader.appendTo(this);}}
> {{ }}}
> would be cleaner.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)