[GitHub] [ignite] akalash commented on a change in pull request #8435: IGNITE-13684 PageIoResolver added

[GitBox <gi...@apache.org>]

akalash commented on a change in pull request #8435:
URL: https://github.com/apache/ignite/pull/8435#discussion_r520400185



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteCacheOffheapManagerImpl.java
##########
@@ -1561,7 +1593,7 @@ void decrementSize(int cacheId) {
                 return grp.mvccEnabled() ? dataTree.isEmpty() : storageSize.get() == 0;
             }
             catch (IgniteCheckedException e) {
-                U.error(log, "Failed to perform operation.", e);
+                U.error(grp.shared().logger(IgniteCacheOffheapManagerImpl.class), "Failed to perform operation.", e);

Review comment:
       Why don't you use log which was set in the constructor?

##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/database/inlinecolumn/ObjectHashInlineIndexColumn.java
##########
@@ -60,7 +63,8 @@ public ObjectHashInlineIndexColumn(Column col) {
 
     /** {@inheritDoc} */
     @Override protected Value get0(long pageAddr, int off) {
-        return null;
+        int hashCode = PageUtils.getInt(pageAddr, off + 1);
+        return new ValueObjectHashCode(hashCode); //TODO Is this ok?

Review comment:
       TODO should be removed

##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryImpl.java
##########
@@ -639,6 +640,7 @@ else if (throttlingPlc == ThrottlingPolicy.CHECKPOINT_BUFFER_ONLY)
      * @return Data region configuration.
      */
     private DataRegionConfiguration getDataRegionConfiguration() {
+        //TODO

Review comment:
       TODO?

##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryImpl.java
##########
@@ -2479,6 +2479,7 @@ private long tryToFindSequentially(int cap, PageStoreWriter saveDirtyPage) throw
 
             DataRegionConfiguration dataRegionCfg = getDataRegionConfiguration();
 
+            //TODO dataRegionCfg is null

Review comment:
       TODO?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org