[jira] [Resolved] (SPARK-46325) Remove unnecessary override functions when constructing `WrappedCloseableIterator` in `ResponseValidator#wrapIterator`

["Dongjoon Hyun (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-46325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dongjoon Hyun resolved SPARK-46325.
-----------------------------------
    Fix Version/s: 4.0.0
       Resolution: Fixed

Issue resolved by pull request 44255
[https://github.com/apache/spark/pull/44255]

> Remove unnecessary override functions when constructing `WrappedCloseableIterator` in `ResponseValidator#wrapIterator`
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: SPARK-46325
>                 URL: https://issues.apache.org/jira/browse/SPARK-46325
>             Project: Spark
>          Issue Type: Improvement
>          Components: Connect
>    Affects Versions: 4.0.0
>            Reporter: Yang Jie
>            Assignee: Yang Jie
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>
> Should reuse functions defined in {{WrappedCloseableIterator}} instead of overriding them
>  
> *ResponseValidator#wrapIterator*
>  
> {code:java}
> def wrapIterator[T <: GeneratedMessageV3, V <: CloseableIterator[T]](
>     inner: V): WrappedCloseableIterator[T] = {
>   new WrappedCloseableIterator[T] {
>     override def innerIterator: Iterator[T] = inner
>     override def hasNext: Boolean = {
>       innerIterator.hasNext
>     }
>     override def next(): T = {
>       verifyResponse {
>         innerIterator.next()
>       }
>     }
>     override def close(): Unit = {
>       innerIterator match {
>         case it: CloseableIterator[T] => it.close()
>         case _ => // nothing
>       }
>     }
>   }
> } {code}
> *WrappedCloseableIterator*
>  
> {code:java}
> private[sql] abstract class WrappedCloseableIterator[E] extends CloseableIterator[E] {
>   def innerIterator: Iterator[E]
>   override def next(): E = innerIterator.next()
>   override def hasNext: Boolean = innerIterator.hasNext
>   override def close(): Unit = innerIterator match {
>     case it: CloseableIterator[E] => it.close()
>     case _ => // nothing
>   }
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org