You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/02/22 11:08:33 UTC

[GitHub] [shardingsphere] lmhmhl opened a new pull request #9470: Issue 9416

lmhmhl opened a new pull request #9470:
URL: https://github.com/apache/shardingsphere/pull/9470


   @tristaZero, Please review the code, Thx.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] lmhmhl commented on pull request #9470: Issue 9416

Posted by GitBox <gi...@apache.org>.

lmhmhl commented on pull request #9470:
URL: https://github.com/apache/shardingsphere/pull/9470#issuecomment-784170272


   > Hi Could you link the relevant issue when you raise the next PR? Therefore the community will know what this PR is for.
   
   I'll pay attention next time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #9470: Issue 9416

Posted by GitBox <gi...@apache.org>.

tristaZero commented on pull request #9470:
URL: https://github.com/apache/shardingsphere/pull/9470#issuecomment-784096156


   Hi Could you link the relevant issue when you raise the next PR? Therefore the community will know what this PR is for.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #9470: Issue 9416

Posted by GitBox <gi...@apache.org>.

codecov-io commented on pull request #9470:
URL: https://github.com/apache/shardingsphere/pull/9470#issuecomment-783860901


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9470?src=pr&el=h1) Report
   > Merging [#9470](https://codecov.io/gh/apache/shardingsphere/pull/9470?src=pr&el=desc) (a37c324) into [master](https://codecov.io/gh/apache/shardingsphere/commit/12c5f72e88f60feafe663ab39e1d9397d37fefc2?el=desc) (12c5f72) will **decrease** coverage by `1.11%`.
   > The diff coverage is `46.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/9470/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/9470?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #9470      +/-   ##
   ============================================
   - Coverage     69.72%   68.60%   -1.12%     
   - Complexity      659      669      +10     
   ============================================
     Files          1649     1653       +4     
     Lines         26664    27263     +599     
     Branches       4638     4804     +166     
   ============================================
   + Hits          18591    18705     +114     
   - Misses         6785     7211     +426     
   - Partials       1288     1347      +59     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/9470?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../agent/exception/PluginConfigurationException.java](https://codecov.io/gh/apache/shardingsphere/pull/9470/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9leGNlcHRpb24vUGx1Z2luQ29uZmlndXJhdGlvbkV4Y2VwdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...gent/core/config/yaml/YamlPluginConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/9470/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9ZYW1sUGx1Z2luQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ig/yaml/swapper/YamlAgentConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/9470/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9zd2FwcGVyL1lhbWxBZ2VudENvbmZpZ3VyYXRpb25Td2FwcGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...re/agent/core/plugin/PluginBootServiceManager.java](https://codecov.io/gh/apache/shardingsphere/pull/9470/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vUGx1Z2luQm9vdFNlcnZpY2VNYW5hZ2VyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...dingsphere/agent/core/spi/PluginServiceLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/9470/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9zcGkvUGx1Z2luU2VydmljZUxvYWRlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ogging/base/advice/SchemaMetaDataLoaderAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/9470/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tbG9nZ2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1sb2dnaW5nLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi9sb2dnaW5nL2Jhc2UvYWR2aWNlL1NjaGVtYU1ldGFEYXRhTG9hZGVyQWR2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...re/agent/metrics/api/reporter/MetricsReporter.java](https://codecov.io/gh/apache/shardingsphere/pull/9470/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tbWV0cmljcy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvbWV0cmljcy9hcGkvcmVwb3J0ZXIvTWV0cmljc1JlcG9ydGVyLmphdmE=) | `54.54% <ø> (+1.21%)` | `0.00 <0.00> (ø)` | |
   | [...lugin/tracing/jaeger/constant/JaegerConstants.java](https://codecov.io/gh/apache/shardingsphere/pull/9470/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tdHJhY2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC10cmFjaW5nLWphZWdlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvcGx1Z2luL3RyYWNpbmcvamFlZ2VyL2NvbnN0YW50L0phZWdlckNvbnN0YW50cy5qYXZh) | `100.00% <ø> (+60.00%)` | `0.00 <0.00> (ø)` | |
   | [...ardingsphere/agent/plugin/tracing/AgentRunner.java](https://codecov.io/gh/apache/shardingsphere/pull/9470/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tdHJhY2luZy9zaGFyZGluZ3NwaGVyZS1hZ2VudC10cmFjaW5nLXRlc3Qvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi90cmFjaW5nL0FnZW50UnVubmVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...re/db/protocol/mysql/constant/MySQLServerInfo.java](https://codecov.io/gh/apache/shardingsphere/pull/9470/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL2NvbnN0YW50L015U1FMU2VydmVySW5mby5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [398 more](https://codecov.io/gh/apache/shardingsphere/pull/9470/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9470?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9470?src=pr&el=footer). Last update [78f7ebc...a37c324](https://codecov.io/gh/apache/shardingsphere/pull/9470?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9470: Issue 9416

Posted by GitBox <gi...@apache.org>.

tristaZero commented on a change in pull request #9470:
URL: https://github.com/apache/shardingsphere/pull/9470#discussion_r580738588



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/auth/builtin/model/user/GranteeTest.java
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.auth.builtin.model.user;
+
+import org.apache.shardingsphere.infra.metadata.auth.model.user.Grantee;
+import org.junit.Test;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertThat;
+
+public class GranteeTest {

Review comment:
       It is better to define it as a final class.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #9470: Issue 9416

Posted by GitBox <gi...@apache.org>.

tristaZero merged pull request #9470:
URL: https://github.com/apache/shardingsphere/pull/9470


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org