You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/24 09:52:03 UTC
[GitHub] [spark] LucaCanali opened a new pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
LucaCanali opened a new pull request #33821:
URL: https://github.com/apache/spark/pull/33821
### What changes were proposed in this pull request?
Currently, the procedure to run the Oracle Integration Suite is based on building the Oracle RDBMS image from the Dockerfiles provided by Oracle.
Recently, Oracle has started providing database images, see https://container-registry.oracle.com
Moreover an Oracle employee is maintaining Oracle XE images that are streamlined for testing at https://hub.docker.com/r/gvenzl/oracle-xe and https://github.com/gvenzl/oci-oracle-xe This solves the issue that official images are quite large and make testing resource-intensive and slow.
This proposes to document the available options and to introduce a default value for ORACLE_DOCKER_IMAGE
### Why are the changes needed?
This change will make it easier and faster to run the Oracle Integration Suite, removing the need to manually build an Oracle DB image.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Manually tested with `./build/sbt -Pdocker-integration-tests "testOnly org.apache.spark.sql.jdbc.OracleIntegrationSuite"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904824204
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142739/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904949921
Thank you for pinging me, @sarutak .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-905025925
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904886989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904823853
**[Test build #142739 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142739/testReport)** for PR 33821 at commit [`50da39b`](https://github.com/apache/spark/commit/50da39b3a1e7f927df2f0d691810f9faf89eb9e1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904660444
**[Test build #142729 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142729/testReport)** for PR 33821 at commit [`ac26324`](https://github.com/apache/spark/commit/ac2632445425c47c794f6f60881e2cb35e96dd8a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LucaCanali commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
LucaCanali commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-905245284
Thank you @sarutak and @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904825370
**[Test build #142740 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142740/testReport)** for PR 33821 at commit [`61634f4`](https://github.com/apache/spark/commit/61634f407d065bbcec252c78fe18827402debd95).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904825704
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142740/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904660444
**[Test build #142729 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142729/testReport)** for PR 33821 at commit [`ac26324`](https://github.com/apache/spark/commit/ac2632445425c47c794f6f60881e2cb35e96dd8a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904879325
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47239/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904825704
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142740/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904672475
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142729/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904672475
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142729/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904495971
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904698961
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47229/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904824204
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142739/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904758071
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47229/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904814297
**[Test build #142740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142740/testReport)** for PR 33821 at commit [`61634f4`](https://github.com/apache/spark/commit/61634f407d065bbcec252c78fe18827402debd95).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904852357
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47240/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904707298
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904495971
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #33821:
URL: https://github.com/apache/spark/pull/33821#discussion_r695019512
##########
File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
##########
@@ -34,42 +34,46 @@ import org.apache.spark.sql.types._
import org.apache.spark.tags.DockerTest
/**
- * The following would be the steps to test this
- * 1. Build Oracle database in Docker, please refer below link about how to.
- * https://github.com/oracle/docker-images/blob/master/OracleDatabase/SingleInstance/README.md
- * 2. export ORACLE_DOCKER_IMAGE_NAME=$ORACLE_DOCKER_IMAGE_NAME
- * Pull oracle $ORACLE_DOCKER_IMAGE_NAME image - docker pull $ORACLE_DOCKER_IMAGE_NAME
- * 3. Start docker - sudo service docker start
- * 4. Run spark test - ./build/sbt -Pdocker-integration-tests
- * "testOnly org.apache.spark.sql.jdbc.OracleIntegrationSuite"
+ * The following are the steps to test this:
*
- * An actual sequence of commands to run the test is as follows
+ * 1. Choose to use a prebuilt image or build Oracle database in a container
+ * - The documentation on how to build Oracle RDBMS in a container is at
+ * https://github.com/oracle/docker-images/blob/master/OracleDatabase/SingleInstance/README.md
+ * - Official Oracle container images can be found at https://container-registry.oracle.com
+ * - A trustable and streamlined Oracle XE database image can be found on Docker Hub at
+ * https://hub.docker.com/r/gvenzl/oracle-xe see also https://github.com/gvenzl/oci-oracle-xe
+ * 2. Run: export ORACLE_DOCKER_IMAGE_NAME=image_you_want_to_use_for_testing
+ * - Example: export ORACLE_DOCKER_IMAGE_NAME=gvenzl/oracle-xe:latest
+ * 3. Run: export ENABLE_DOCKER_INTEGRATION_TESTS=1
+ * 4. Start docker: sudo service docker start
+ * - Optionally, docker pull $ORACLE_DOCKER_IMAGE_NAME
+ * 5. Run Spark integration tests for Oracle with: ./build/sbt -Pdocker-integration-tests
+ * "testOnly org.apache.spark.sql.jdbc.OracleIntegrationSuite"
*
+ * A sequence of commands to build the Oracle XE database container image:
* $ git clone https://github.com/oracle/docker-images.git
- * // Head SHA: 3f422c4a35b423dfcdbcc57a84f01db6c82eb6c1
* $ cd docker-images/OracleDatabase/SingleInstance/dockerfiles
* $ ./buildContainerImage.sh -v 18.4.0 -x
* $ export ORACLE_DOCKER_IMAGE_NAME=oracle/database:18.4.0-xe
- * $ export ENABLE_DOCKER_INTEGRATION_TESTS=1
- * $ cd $SPARK_HOME
- * $ ./build/sbt -Pdocker-integration-tests
- * "testOnly org.apache.spark.sql.jdbc.OracleIntegrationSuite"
*
- * It has been validated with 18.4.0 Express Edition.
+ * This procedure has been validated with Oracle 18.4.0 Express Edition.
*/
@DockerTest
class OracleIntegrationSuite extends DockerJDBCIntegrationSuite with SharedSparkSession {
import testImplicits._
override val db = new DatabaseOnDocker {
- lazy override val imageName = sys.env("ORACLE_DOCKER_IMAGE_NAME")
+ lazy override val imageName =
+ sys.env.getOrElse("ORACLE_DOCKER_IMAGE_NAME", "gvenzl/oracle-xe:latest")
Review comment:
Oh, it's better to pin the tag rather than `latest` for the reproducibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904658663
@LucaCanali Could you apply this change for `v2.OracleIntegrationSuite` too?
Also, could you reflect this change to GA job by chainging `build_and_test.yml`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904810968
**[Test build #142739 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142739/testReport)** for PR 33821 at commit [`50da39b`](https://github.com/apache/spark/commit/50da39b3a1e7f927df2f0d691810f9faf89eb9e1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904810968
**[Test build #142739 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142739/testReport)** for PR 33821 at commit [`50da39b`](https://github.com/apache/spark/commit/50da39b3a1e7f927df2f0d691810f9faf89eb9e1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904844288
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47239/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904886989
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47239/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904658344
ok to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #33821:
URL: https://github.com/apache/spark/pull/33821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904707298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904887411
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47240/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-905972580
Nice, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904814297
**[Test build #142740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142740/testReport)** for PR 33821 at commit [`61634f4`](https://github.com/apache/spark/commit/61634f407d065bbcec252c78fe18827402debd95).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904953376
Merged to master for Apache Spark 3.3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904887378
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47240/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904672130
**[Test build #142729 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142729/testReport)** for PR 33821 at commit [`ac26324`](https://github.com/apache/spark/commit/ac2632445425c47c794f6f60881e2cb35e96dd8a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33821: [SPARK-36573][BUILD][TEST] Add a default value to ORACLE_DOCKER_IMAGE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33821:
URL: https://github.com/apache/spark/pull/33821#issuecomment-904745876
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47229/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org