[GitHub] [mina-sshd] tomaswolf commented on pull request #223: [SSHD-1262] Eliminate buffering in TCP/IP port forwarding

[GitBox <gi...@apache.org>]

tomaswolf commented on PR #223:
URL: https://github.com/apache/mina-sshd/pull/223#issuecomment-1126787277

   > I was not able to determine whether pending peer packets are flushed before EOF is sent and the channel is closed.
   
   They should be. On a graceful close, the channel first closes the `ChannelAsyncOutputStream` gracefully. The stream's close future is fulfilled only once the last write has been completed. Sending the EOF happens in a future listener on the stream's close future, so it goes out after the stream is closed, and it's done not via the stream but directly via the SSH session.
   
   See [TcpipServerChannel, lines 208ff](https://github.com/apache/mina-sshd/blob/d656a1edd55c56e7a37878ebc3cbd15ee0065eb4/sshd-core/src/main/java/org/apache/sshd/server/forward/TcpipServerChannel.java#L208) and [TcpipClientChannel, lines 157ff](https://github.com/apache/mina-sshd/blob/d656a1edd55c56e7a37878ebc3cbd15ee0065eb4/sshd-core/src/main/java/org/apache/sshd/common/forward/TcpipClientChannel.java#L157). I've added comments at both places.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org