Apache/TestConfig.pm patch

[Stas Bekman <st...@stason.org>]

t/TEST -clean
Use of uninitialized value in string eq at
Apache-Test/lib/Apache/TestConfig.pm line 775.
make: *** [test_clean] Error 2


here is a possible patch to fix the problem, or probably need to use
exists() for a cleaner way.

Index: Apache-Test/lib/Apache/TestConfig.pm
===================================================================
RCS file:
/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig.pm,v
retrieving revision 1.30
diff -u -r1.30 TestConfig.pm
--- Apache-Test/lib/Apache/TestConfig.pm	2001/08/13 04:08:06
1.30
+++ Apache-Test/lib/Apache/TestConfig.pm	2001/08/13 04:17:52
@@ -772,7 +772,9 @@
     my $thaw = $self->thaw;

     for my $key (@_) {
-        next if $thaw->{vars}->{$key} eq $self->{vars}->{$key};
+        next if $thaw->{vars}->{$key} &&
+            $self->{vars}->{$key} &&
+            $thaw->{vars}->{$key} eq $self->{vars}->{$key};
         $thaw->{vars}->{$key} = $self->{vars}->{$key};
         $changed = 1;
     }




_____________________________________________________________________
Stas Bekman              JAm_pH     --   Just Another mod_perl Hacker
http://stason.org/       mod_perl Guide  http://perl.apache.org/guide
mailto:stas@stason.org   http://apachetoday.com http://eXtropia.com/
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/

Re: Apache/TestConfig.pm patch

[Doug MacEachern <do...@covalent.net>]

On Mon, 13 Aug 2001, Stas Bekman wrote:

> t/TEST -clean
> Use of uninitialized value in string eq at
> Apache-Test/lib/Apache/TestConfig.pm line 775.
> make: *** [test_clean] Error 2

doh!  thanks, i put the fix in using exists.