You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Pieter Berkel (JIRA)" <ji...@apache.org> on 2007/08/01 02:39:53 UTC

[jira] Issue Comment Edited: (SOLR-301) Clean up param interface. Leave deprecated options in deprecated classes

    [ https://issues.apache.org/jira/browse/SOLR-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516839 ] 

Pieter Berkel edited comment on SOLR-301 at 7/31/07 5:39 PM:
-------------------------------------------------------------

While you're in the process of cleaning up the Params interfaces, I wonder if it worthwhile moving MoreLikeThisParams from o.a.s.common.util to o.a.s.common.params at the same time?  I made a note of this in my comments on SOLR-295.


 was:
While you're in the process of cleaning up the Params interfaces, I wonder if it worthwhile moving MoreLikeThisParams from o.a.s.common.util to o.a.s.common.params at the same time?  I made a note of this in my comments on <a href="http://issues.apache.org/jira/browse/SOLR-295">SOLR-295</a>.

> Clean up param interface.  Leave deprecated options in deprecated classes
> -------------------------------------------------------------------------
>
>                 Key: SOLR-301
>                 URL: https://issues.apache.org/jira/browse/SOLR-301
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>            Assignee: Ryan McKinley
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-301-ParamCleanup.patch, SOLR-301-ParamCleanup.patch
>
>
> In SOLR-135, we moved the parameter handling stuff to a new package: o.a.s.common.params and left @deprecated classes in the old location.
> Classes in the new package should not contain any deprecated options. 
> Aditionally, we should aim to seperate parameter manipulation logic (DefaultSolrParams, AppendedSolrParams, etc) from 'parameter' interface classes: 'HighlightParams', 'UpdateParams'

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.