You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by vs...@apache.org on 2009/08/13 14:07:42 UTC
svn commit: r803853 - in /maven/plugins/trunk/maven-pmd-plugin/src:
main/java/org/apache/maven/plugin/pmd/ test/java/org/apache/maven/plugin/pmd/
test/java/org/apache/maven/plugin/pmd/stubs/
Author: vsiveton
Date: Thu Aug 13 12:07:41 2009
New Revision: 803853
URL: http://svn.apache.org/viewvc?rev=803853&view=rev
Log:
o javadoc
Modified:
maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdReport.java
maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java
maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java
maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojo.java
maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdFileInfo.java
maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java
maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java
maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojo.java
maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java
maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojoTest.java
maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdReportTest.java
maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojoTest.java
maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/CustomConfigurationMavenProjectStub.java
maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/DefaultArtifactHandlerStub.java
maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/DefaultConfigurationMavenProjectStub.java
maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/InvalidFormatMavenProjectStub.java
maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/PmdPluginArtifactStub.java
Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdReport.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdReport.java?rev=803853&r1=803852&r2=803853&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdReport.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdReport.java Thu Aug 13 12:07:41 2009
@@ -44,6 +44,7 @@
* Base class for the PMD reports.
*
* @author <a href="mailto:brett@apache.org">Brett Porter</a>
+ * @version $Id$
*/
public abstract class AbstractPmdReport
extends AbstractMavenReport
@@ -185,17 +186,13 @@
*/
protected List reactorProjects;
- /**
- * @see org.apache.maven.reporting.AbstractMavenReport#getProject()
- */
+ /** {@inheritDoc} */
protected MavenProject getProject()
{
return project;
}
- /**
- * @see org.apache.maven.reporting.AbstractMavenReport#getSiteRenderer()
- */
+ /** {@inheritDoc} */
protected Renderer getSiteRenderer()
{
return siteRenderer;
@@ -379,9 +376,7 @@
return "html".equals( format );
}
- /**
- * @see org.apache.maven.reporting.AbstractMavenReport#canGenerateReport()
- */
+ /** {@inheritDoc} */
public boolean canGenerateReport()
{
if ( aggregate && !project.isExecutionRoot() )
@@ -415,9 +410,7 @@
return true;
}
- /**
- * @see org.apache.maven.reporting.AbstractMavenReport#getOutputDirectory()
- */
+ /** {@inheritDoc} */
protected String getOutputDirectory()
{
return outputDirectory.getAbsolutePath();
Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java?rev=803853&r1=803852&r2=803853&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java Thu Aug 13 12:07:41 2009
@@ -39,8 +39,9 @@
/**
* Base class for mojos that check if there were any PMD violations.
- *
+ *
* @author <a href="mailto:brett@apache.org">Brett Porter</a>
+ * @version $Id$
*/
public abstract class AbstractPmdViolationCheckMojo
extends AbstractMojo
@@ -51,7 +52,7 @@
/**
* The location of the XML report to check, as generated by the PMD report.
- *
+ *
* @parameter expression="${project.build.directory}"
* @required
*/
@@ -59,7 +60,7 @@
/**
* Whether to fail the build if the validation check fails.
- *
+ *
* @parameter expression="${pmd.failOnViolation}" default-value="true"
* @required
*/
@@ -67,7 +68,7 @@
/**
* The project language, for determining whether to run the report.
- *
+ *
* @parameter expression="${project.artifact.artifactHandler.language}"
* @required
* @readonly
@@ -81,14 +82,14 @@
* @since 2.2
*/
protected boolean aggregate;
-
+
/**
* Print details of check failures to build output.
- *
+ *
* @parameter expression="${pmd.verbose}" default-value="false"
*/
private boolean verbose;
-
+
/**
* The project to analyse.
*
@@ -105,7 +106,7 @@
{
return;
}
-
+
if ( "java".equals( language ) || aggregate )
{
File outputFile = new File( targetDirectory, filename );
@@ -162,7 +163,7 @@
/**
* Method for collecting the violations found by the PMD tool
- *
+ *
* @param xpp
* the xml parser object
* @param tagName
@@ -222,7 +223,7 @@
/**
* Prints the warnings and failures
- *
+ *
* @param failures
* list of failures
* @param warnings
@@ -245,7 +246,7 @@
/**
* Gets the output message
- *
+ *
* @param failureCount
* @param warningCount
* @param key
@@ -282,7 +283,7 @@
/**
* Formats the failure details and prints them as an INFO message
- *
+ *
* @param item
*/
protected abstract void printError( Map item, String severity );
@@ -290,7 +291,7 @@
/**
* Gets the attributes and text for the violation tag and puts them in a
* HashMap
- *
+ *
* @param xpp
* @throws XmlPullParserException
* @throws IOException
Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java?rev=803853&r1=803852&r2=803853&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java Thu Aug 13 12:07:41 2009
@@ -74,31 +74,25 @@
/**
* The file encoding to use when reading the Java sources.
- *
+ *
* @parameter expression="${encoding}" default-value="${project.build.sourceEncoding}"
* @since 2.3
*/
private String sourceEncoding;
- /**
- * @see org.apache.maven.reporting.MavenReport#getName(java.util.Locale)
- */
+ /** {@inheritDoc} */
public String getName( Locale locale )
{
return getBundle( locale ).getString( "report.cpd.name" );
}
- /**
- * @see org.apache.maven.reporting.MavenReport#getDescription(java.util.Locale)
- */
+ /** {@inheritDoc} */
public String getDescription( Locale locale )
{
return getBundle( locale ).getString( "report.cpd.description" );
}
- /**
- * @see org.apache.maven.reporting.AbstractMavenReport#executeReport(java.util.Locale)
- */
+ /** {@inheritDoc} */
public void executeReport( Locale locale )
throws MavenReportException
{
@@ -119,12 +113,12 @@
throws MavenReportException
{
if ( !skip && canGenerateReport() )
- {
+ {
ClassLoader origLoader = Thread.currentThread().getContextClassLoader();
try
{
Thread.currentThread().setContextClassLoader( this.getClass().getClassLoader() );
-
+
CPD cpd = new CPD( minimumTokens, new JavaLanguage() );
Map files = null;
try
@@ -145,7 +139,7 @@
+ WriterFactory.FILE_ENCODING + ", i.e. build is platform dependent!" );
}
- for ( Iterator it = files.keySet().iterator(); it.hasNext(); )
+ for ( Iterator it = files.keySet().iterator(); it.hasNext(); )
{
cpd.add( (File) it.next() );
}
@@ -159,11 +153,11 @@
throw new MavenReportException( e.getMessage(), e );
}
cpd.go();
-
+
CpdReportGenerator gen =
new CpdReportGenerator( getSink(), files, getBundle( locale ), aggregate );
gen.generate( cpd.getMatches() );
-
+
if ( !isHtml() )
{
writeNonHtml( cpd );
@@ -214,9 +208,7 @@
}
}
- /**
- * @see org.apache.maven.reporting.MavenReport#getOutputName()
- */
+ /** {@inheritDoc} */
public String getOutputName()
{
return "cpd";
Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojo.java?rev=803853&r1=803852&r2=803853&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojo.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojo.java Thu Aug 13 12:07:41 2009
@@ -32,6 +32,7 @@
* Fail the build if there were any CPD violations in the source code.
*
* @since 2.0
+ * @version $Id$
* @goal cpd-check
* @phase verify
* @execute goal="cpd"
@@ -47,10 +48,8 @@
* @parameter expression="${cpd.skip}" default-value="false"
*/
private boolean skip;
-
- /**
- * @see org.apache.maven.plugin.AbstractMojo#execute()
- */
+
+ /** {@inheritDoc} */
public void execute()
throws MojoExecutionException, MojoFailureException
{
@@ -59,42 +58,39 @@
executeCheck( "cpd.xml", "duplication", "CPD duplication", 10 );
}
}
-
- /**
- * Formats the failure details and prints them as an INFO message
- *
- * @param item
- */
+
+ /** {@inheritDoc} */
protected void printError( Map item, String severity )
{
String lines = (String) item.get( "lines" );
-
-
+
+
StringBuffer buff = new StringBuffer( 100 );
buff.append( "CPD " + severity + ": Found " );
buff.append( lines ).append( " lines of duplicated code at locations:" );
this.getLog().info( buff.toString() );
-
+
buff.setLength( 0 );
buff.append( " " );
Map file = (Map) item.get( "file" );
buff.append( file.get( "path" ) );
buff.append( " line " ).append( file.get( "line" ) );
this.getLog().info( buff.toString() );
-
+
buff.setLength( 0 );
buff.append( " " );
file = (Map) item.get( "file1" );
buff.append( file.get( "path" ) );
buff.append( " line " ).append( file.get( "line" ) );
this.getLog().info( buff.toString() );
-
+
Map codefrag = (Map) item.get( "codefragment" );
String codefragstr = (String) codefrag.get( "text" );
this.getLog().debug( "CPD " + severity + ": Code Fragment " );
this.getLog().debug( codefragstr );
}
+ /** {@inheritDoc} */
protected Map getErrorDetails( XmlPullParser xpp )
throws XmlPullParserException, IOException
{
@@ -114,7 +110,7 @@
while ( tp != XmlPullParser.END_TAG )
{
// get the tag's text
- switch ( tp )
+ switch ( tp )
{
case XmlPullParser.TEXT:
msgs.put( "text", xpp.getText().trim() );
Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdFileInfo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdFileInfo.java?rev=803853&r1=803852&r2=803853&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdFileInfo.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdFileInfo.java Thu Aug 13 12:07:41 2009
@@ -23,17 +23,20 @@
import org.apache.maven.project.MavenProject;
-public class PmdFileInfo
+/**
+ * @version $Id$
+ */
+public class PmdFileInfo
{
-
+
private MavenProject project;
private File sourceDir;
private String xref;
-
-
+
+
public PmdFileInfo( MavenProject project,
File dir,
- String x )
+ String x )
{
this.project = project;
if ( dir.isAbsolute() )
@@ -46,22 +49,22 @@
}
this.xref = x;
}
-
-
+
+
public String getXrefLocation()
{
return xref;
}
-
- public File getSourceDirectory()
+
+ public File getSourceDirectory()
{
return sourceDir;
}
-
- public MavenProject getProject()
+
+ public MavenProject getProject()
{
return project;
}
-
+
}
Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java?rev=803853&r1=803852&r2=803853&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java Thu Aug 13 12:07:41 2009
@@ -121,14 +121,13 @@
*/
private ResourceManager locator;
-
- /** @see org.apache.maven.reporting.MavenReport#getName(java.util.Locale) */
+ /** {@inheritDoc} */
public String getName( Locale locale )
{
return getBundle( locale ).getString( "report.pmd.name" );
}
- /** @see org.apache.maven.reporting.MavenReport#getDescription(java.util.Locale) */
+ /** {@inheritDoc} */
public String getDescription( Locale locale )
{
return getBundle( locale ).getString( "report.pmd.description" );
@@ -139,7 +138,7 @@
rulesets = rules;
}
- /** @see org.apache.maven.reporting.AbstractMavenReport#executeReport(java.util.Locale) */
+ /** {@inheritDoc} */
public void executeReport( Locale locale )
throws MavenReportException
{
@@ -392,7 +391,7 @@
return pmd;
}
- /** @see org.apache.maven.reporting.MavenReport#getOutputName() */
+ /** {@inheritDoc} */
public String getOutputName()
{
return "pmd";
@@ -467,61 +466,73 @@
this.description = description;
}
+ /** {@inheritDoc} */
public String getFilename()
{
return this.filename;
}
+ /** {@inheritDoc} */
public int getBeginLine()
{
return 0;
}
+ /** {@inheritDoc} */
public int getBeginColumn()
{
return 0;
}
+ /** {@inheritDoc} */
public int getEndLine()
{
return 0;
}
+ /** {@inheritDoc} */
public int getEndColumn()
{
return 0;
}
+ /** {@inheritDoc} */
public Rule getRule()
{
return null;
}
+ /** {@inheritDoc} */
public String getDescription()
{
return this.description;
}
+ /** {@inheritDoc} */
public String getPackageName()
{
return null;
}
+ /** {@inheritDoc} */
public String getMethodName()
{
return null;
}
+ /** {@inheritDoc} */
public String getClassName()
{
return null;
}
+ /** {@inheritDoc} */
public boolean isSuppressed()
{
return false;
}
+ /** {@inheritDoc} */
public String getVariableName()
{
return null;
Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java?rev=803853&r1=803852&r2=803853&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java Thu Aug 13 12:07:41 2009
@@ -75,6 +75,7 @@
return bundle.getString( "report.pmd.title" );
}
+ /** {@inheritDoc} */
public void ruleViolationAdded( IRuleViolation ruleViolation )
{
if ( !fileInitialized )
@@ -111,6 +112,7 @@
fileCount++;
Collections.sort( violations, new Comparator()
{
+ /** {@inheritDoc} */
public int compare( Object o1, Object o2 )
{
return ( (IRuleViolation) o1 ).getBeginLine()
@@ -157,6 +159,7 @@
}
}
+ /** {@inheritDoc} */
public void metricAdded( Metric metric )
{
// if ( metric.getCount() != 0 )
Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojo.java?rev=803853&r1=803852&r2=803853&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojo.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojo.java Thu Aug 13 12:07:41 2009
@@ -30,8 +30,9 @@
/**
* Fail the build if there were any PMD violations in the source code.
- *
+ *
* @since 2.0
+ * @version $Id$
* @goal check
* @phase verify
* @execute goal="pmd"
@@ -44,7 +45,7 @@
* will stop the build. Anything below will be warnings and will be
* displayed in the build output if verbose=true. Note: Minumum Priority = 5
* Maximum Priority = 0
- *
+ *
* @parameter expression="${pmd.failurePriority}" default-value="5"
* @required
*/
@@ -57,10 +58,8 @@
* @parameter expression="${pmd.skip}" default-value="false"
*/
private boolean skip;
-
- /**
- * @see org.apache.maven.plugin.AbstractMojo#execute()
- */
+
+ /** {@inheritDoc} */
public void execute()
throws MojoExecutionException, MojoFailureException
{
@@ -70,12 +69,7 @@
}
}
- /**
- * Formats the failure details and prints them as an INFO message
- *
- * @param item
- * parsed details about error
- */
+ /** {@inheritDoc} */
protected void printError( Map item, String severity )
{
@@ -99,14 +93,7 @@
this.getLog().info( buff.toString() );
}
- /**
- * Gets the attributes and text for the violation tag and puts them in a
- * HashMap
- *
- * @param xpp
- * @throws XmlPullParserException
- * @throws IOException
- */
+ /** {@inheritDoc} */
protected Map getErrorDetails( XmlPullParser xpp )
throws XmlPullParserException, IOException
{
@@ -130,5 +117,4 @@
}
return msgs;
}
-
}
Modified: maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java?rev=803853&r1=803852&r2=803853&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java Thu Aug 13 12:07:41 2009
@@ -41,11 +41,12 @@
/**
* @author <a href="mailto:oching@apache.org">Maria Odea Ching</a>
+ * @version $Id$
*/
public class CpdReportTest
extends AbstractPmdReportTest
{
-
+ /** {@inheritDoc} */
protected void setUp()
throws Exception
{
@@ -158,12 +159,6 @@
}
- protected void tearDown()
- throws Exception
- {
-
- }
-
/**
* Read the contents of the specified file object into a string
*
Modified: maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojoTest.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojoTest.java?rev=803853&r1=803852&r2=803853&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojoTest.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojoTest.java Thu Aug 13 12:07:41 2009
@@ -26,11 +26,12 @@
/**
* @author <a href="mailto:oching@apache.org">Maria Odea Ching</a>
+ * @version $Id$
*/
public class CpdViolationCheckMojoTest
extends AbstractMojoTestCase
{
-
+ /** {@inheritDoc} */
protected void setUp()
throws Exception
{
@@ -89,10 +90,4 @@
assertTrue( true );
}
}
-
- protected void tearDown()
- throws Exception
- {
-
- }
}
Modified: maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdReportTest.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdReportTest.java?rev=803853&r1=803852&r2=803853&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdReportTest.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdReportTest.java Thu Aug 13 12:07:41 2009
@@ -29,10 +29,12 @@
/**
* @author <a href="mailto:oching@apache.org">Maria Odea Ching</a>
+ * @version $Id$
*/
public class PmdReportTest
extends AbstractPmdReportTest
{
+ /** {@inheritDoc} */
protected void setUp()
throws Exception
{
Modified: maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojoTest.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojoTest.java?rev=803853&r1=803852&r2=803853&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojoTest.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojoTest.java Thu Aug 13 12:07:41 2009
@@ -26,11 +26,12 @@
/**
* @author <a href="mailto:oching@apache.org">Maria Odea Ching</a>
+ * @version $Id$
*/
public class PmdViolationCheckMojoTest
extends AbstractMojoTestCase
{
-
+ /** {@inheritDoc} */
protected void setUp()
throws Exception
{
@@ -112,11 +113,4 @@
}
}
-
- protected void tearDown()
- throws Exception
- {
-
- }
-
}
Modified: maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/CustomConfigurationMavenProjectStub.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/CustomConfigurationMavenProjectStub.java?rev=803853&r1=803852&r2=803853&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/CustomConfigurationMavenProjectStub.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/CustomConfigurationMavenProjectStub.java Thu Aug 13 12:07:41 2009
@@ -33,6 +33,7 @@
/**
* @author <a href="mailto:oching@apache.org">Maria Odea Ching</a>
+ * @version $Id$
*/
public class CustomConfigurationMavenProjectStub
extends MavenProjectStub
@@ -88,11 +89,13 @@
setFile(new File(getBasedir().getAbsolutePath() + "/pom.xml"));
}
+ /** {@inheritDoc} */
public void setBuild( Build build )
{
this.build = build;
}
+ /** {@inheritDoc} */
public Build getBuild()
{
return build;
@@ -103,6 +106,7 @@
this.reportPlugins = plugins;
}
+ /** {@inheritDoc} */
public List getReportPlugins()
{
return reportPlugins;
Modified: maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/DefaultArtifactHandlerStub.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/DefaultArtifactHandlerStub.java?rev=803853&r1=803852&r2=803853&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/DefaultArtifactHandlerStub.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/DefaultArtifactHandlerStub.java Thu Aug 13 12:07:41 2009
@@ -23,12 +23,14 @@
/**
* @author <a href="mailto:oching@apache.org">Maria Odea Ching</a>
+ * @version $Id$
*/
public class DefaultArtifactHandlerStub
extends DefaultArtifactHandler
{
private String language;
+ /** {@inheritDoc} */
public String getLanguage()
{
if ( language == null )
Modified: maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/DefaultConfigurationMavenProjectStub.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/DefaultConfigurationMavenProjectStub.java?rev=803853&r1=803852&r2=803853&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/DefaultConfigurationMavenProjectStub.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/DefaultConfigurationMavenProjectStub.java Thu Aug 13 12:07:41 2009
@@ -33,6 +33,7 @@
/**
* @author <a href="mailto:oching@apache.org">Maria Odea Ching</a>
+ * @version $Id$
*/
public class DefaultConfigurationMavenProjectStub
extends MavenProjectStub
@@ -80,7 +81,7 @@
List compileSourceRoots = new ArrayList();
compileSourceRoots.add( basedir + "/src/test/resources/unit/default-configuration/def/configuration" );
setCompileSourceRoots( compileSourceRoots );
-
+
File file = new File(getBasedir().getAbsolutePath() + "/pom.xml");
setFile(file);
@@ -95,19 +96,21 @@
this.reportPlugins = plugins;
}
+ /** {@inheritDoc} */
public List getReportPlugins()
{
return reportPlugins;
}
+ /** {@inheritDoc} */
public void setBuild( Build build )
{
this.build = build;
}
+ /** {@inheritDoc} */
public Build getBuild()
{
return build;
}
-
}
Modified: maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/InvalidFormatMavenProjectStub.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/InvalidFormatMavenProjectStub.java?rev=803853&r1=803852&r2=803853&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/InvalidFormatMavenProjectStub.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/InvalidFormatMavenProjectStub.java Thu Aug 13 12:07:41 2009
@@ -33,6 +33,7 @@
/**
* @author <a href="mailto:oching@apache.org">Maria Odea Ching</a>
+ * @version $Id$
*/
public class InvalidFormatMavenProjectStub
extends MavenProjectStub
@@ -80,19 +81,20 @@
Artifact artifact = new PmdPluginArtifactStub( getGroupId(), getArtifactId(), getVersion(), getPackaging() );
artifact.setArtifactHandler( new DefaultArtifactHandlerStub() );
setArtifact( artifact );
-
+
setFile(new File(getBasedir().getAbsolutePath() + "/pom.xml"));
}
+ /** {@inheritDoc} */
public void setBuild( Build build )
{
this.build = build;
}
+ /** {@inheritDoc} */
public Build getBuild()
{
return build;
}
-
}
Modified: maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/PmdPluginArtifactStub.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/PmdPluginArtifactStub.java?rev=803853&r1=803852&r2=803853&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/PmdPluginArtifactStub.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/stubs/PmdPluginArtifactStub.java Thu Aug 13 12:07:41 2009
@@ -25,6 +25,7 @@
/**
* @author <a href="mailto:oching@apache.org">Maria Odea Ching</a>
+ * @version $Id$
*/
public class PmdPluginArtifactStub
extends ArtifactStub
@@ -50,31 +51,37 @@
versionRange = VersionRange.createFromVersion( version );
}
+ /** {@inheritDoc} */
public void setGroupId( String groupId )
{
this.groupId = groupId;
}
+ /** {@inheritDoc} */
public String getGroupId()
{
return groupId;
}
+ /** {@inheritDoc} */
public void setArtifactId( String artifactId )
{
this.artifactId = artifactId;
}
+ /** {@inheritDoc} */
public String getArtifactId()
{
return artifactId;
}
+ /** {@inheritDoc} */
public void setVersion( String version )
{
this.version = version;
}
+ /** {@inheritDoc} */
public String getVersion()
{
return version;
@@ -90,21 +97,25 @@
return packaging;
}
+ /** {@inheritDoc} */
public VersionRange getVersionRange()
{
return versionRange;
}
+ /** {@inheritDoc} */
public void setVersionRange( VersionRange versionRange )
{
this.versionRange = versionRange;
}
+ /** {@inheritDoc} */
public ArtifactHandler getArtifactHandler()
{
return handler;
}
+ /** {@inheritDoc} */
public void setArtifactHandler( ArtifactHandler handler )
{
this.handler = handler;