You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/05 16:04:13 UTC
[GitHub] [skywalking] codecov-io commented on issue #4441: Add finagle
plugin (#4433)
codecov-io commented on issue #4441: Add finagle plugin (#4433)
URL: https://github.com/apache/skywalking/pull/4441#issuecomment-595307764
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4441?src=pr&el=h1) Report
> Merging [#4441](https://codecov.io/gh/apache/skywalking/pull/4441?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0df2d0a5e9210e0c2a6c4f7e5fe350d3aa21cab0?src=pr&el=desc) will **increase** coverage by `0.39%`.
> The diff coverage is `62.11%`.
[](https://codecov.io/gh/apache/skywalking/pull/4441?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4441 +/- ##
==========================================
+ Coverage 25.14% 25.53% +0.39%
==========================================
Files 1223 1235 +12
Lines 28293 28615 +322
Branches 3890 3926 +36
==========================================
+ Hits 7115 7308 +193
- Misses 20521 20631 +110
- Partials 657 676 +19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4441?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../define/ClientDestTracingFilterInstrumetation.java](https://codecov.io/gh/apache/skywalking/pull/4441/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9kZWZpbmUvQ2xpZW50RGVzdFRyYWNpbmdGaWx0ZXJJbnN0cnVtZXRhdGlvbi5qYXZh) | `0% <0%> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4441/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...plugin/finagle/ClientTracingFilterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4441/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9DbGllbnRUcmFjaW5nRmlsdGVySW50ZXJjZXB0b3IuamF2YQ==) | `100% <100%> (ø)` | |
| [...lking/apm/plugin/finagle/ContextHolderFactory.java](https://codecov.io/gh/apache/skywalking/pull/4441/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9Db250ZXh0SG9sZGVyRmFjdG9yeS5qYXZh) | `34.82% <34.82%> (ø)` | |
| [...alking/apm/plugin/finagle/AbstractInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4441/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9BYnN0cmFjdEludGVyY2VwdG9yLmphdmE=) | `43.75% <43.75%> (ø)` | |
| [...in/finagle/ClientDestTracingFilterInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4441/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9DbGllbnREZXN0VHJhY2luZ0ZpbHRlckludGVyY2VwdG9yLmphdmE=) | `52.38% <52.38%> (ø)` | |
| [...ywalking/apm/plugin/finagle/SWContextCarrier.scala](https://codecov.io/gh/apache/skywalking/pull/4441/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL2ZpbmFnbGUvU1dDb250ZXh0Q2Fycmllci5zY2FsYQ==) | `66.66% <66.66%> (ø)` | |
| [...lking/apm/plugin/finagle/ContextCarrierHelper.java](https://codecov.io/gh/apache/skywalking/pull/4441/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9Db250ZXh0Q2FycmllckhlbHBlci5qYXZh) | `72.72% <72.72%> (ø)` | |
| [...lking/apm/plugin/finagle/CompatibilityChecker.java](https://codecov.io/gh/apache/skywalking/pull/4441/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9Db21wYXRpYmlsaXR5Q2hlY2tlci5qYXZh) | `73.33% <73.33%> (ø)` | |
| [...che/skywalking/apm/plugin/finagle/FinagleCtxs.java](https://codecov.io/gh/apache/skywalking/pull/4441/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vZmluYWdsZS02LjI1LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vZmluYWdsZS9GaW5hZ2xlQ3R4cy5qYXZh) | `76.47% <76.47%> (ø)` | |
| ... and [16 more](https://codecov.io/gh/apache/skywalking/pull/4441/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4441?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4441?src=pr&el=footer). Last update [0df2d0a...4ed9a08](https://codecov.io/gh/apache/skywalking/pull/4441?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services