You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/29 12:18:15 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #4115: cks: fix k8s cluster deployment planner
shwstppr opened a new pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115
## Description
Fixes #4113
Check for compute offering host tags while finding suitable host/deployment destination for k8s cluster node VM during deploy and scale cluster.
Check for k8s cluster template's hypervisor type during scale as template is tied to the k8s cluster therefore new node VM must be deployed in the same hypervisor host.
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-641097828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-635941820
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-636208481
<b>Trillian test result (tid-1589)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32128 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4115-t1589-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_kubernetes_cluster | `Error` | 0.05 | test_kubernetes_clusters.py
test_02_deploy_kubernetes_ha_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.02 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-647028470
@shwstppr can you please add a bug description and a test scenario?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-642565308
Packaging result: ✔centos7 ✖debian. JID-1339
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-642592449
Packaging result: ✔centos7 ✔debian. JID-1347
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-643672212
<b>Trillian test result (tid-1714)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50350 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4115-t1714-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-642536262
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-644550538
@shwstppr is this ready for review/testing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-640445433
Packaging result: ✔centos7 ✔debian. JID-1312
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-635941503
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-635445412
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr edited a comment on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
shwstppr edited a comment on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-649011685
Moved #4116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-643573715
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-635444728
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-643573647
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-642535816
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-649011685
Closed in favour of #4116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-641113846
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-635460103
Packaging result: ✔centos7 ✔debian. JID-1254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-648556748
@shwstppr can you club your cks PRs, and at least change base branch to 4.14?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #4115: cks: fix k8s cluster deployment planner
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #4115:
URL: https://github.com/apache/cloudstack/pull/4115
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org