You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "ibilley7 (via GitHub)" <gi...@apache.org> on 2025/06/02 15:30:13 UTC
[PR] Convert multi-assignments to single assignments [accumulo]
ibilley7 opened a new pull request, #5608:
URL: https://github.com/apache/accumulo/pull/5608
A number of classes contain multiple variables assigned on the same line. Break up these assignments to separate lines.
Closes #3689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Convert multi-assignments to single assignments [accumulo]
Posted by "ibilley7 (via GitHub)" <gi...@apache.org>.
ibilley7 commented on code in PR #5608:
URL: https://github.com/apache/accumulo/pull/5608#discussion_r2121811779
##########
core/src/test/java/org/apache/accumulo/core/iterators/user/RegExFilterTest.java:
##########
@@ -248,8 +248,10 @@ public void test1() throws IOException {
public void testNullByteInKey() throws IOException {
TreeMap<Key,Value> tm = new TreeMap<>();
- String s1 = "first", s2 = "second";
- byte[] b1 = s1.getBytes(UTF_8), b2 = s2.getBytes(UTF_8), ball;
+ String s1 = "first";
+ String s2 = "second";
+ byte[] b1 = s1.getBytes(UTF_8);
+ byte[] b2 = s2.getBytes(UTF_8), ball;
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Convert multi-assignments to single assignments [accumulo]
Posted by "ddanielr (via GitHub)" <gi...@apache.org>.
ddanielr commented on code in PR #5608:
URL: https://github.com/apache/accumulo/pull/5608#discussion_r2121969465
##########
shell/src/main/java/org/apache/accumulo/shell/commands/InsertCommand.java:
##########
@@ -33,10 +33,7 @@
import org.apache.accumulo.core.client.TableNotFoundException;
import org.apache.accumulo.core.client.security.SecurityErrorCode;
import org.apache.accumulo.core.conf.ConfigurationTypeHelper;
-import org.apache.accumulo.core.data.ConstraintViolationSummary;
-import org.apache.accumulo.core.data.Mutation;
-import org.apache.accumulo.core.data.TabletId;
-import org.apache.accumulo.core.data.Value;
+import org.apache.accumulo.core.data.*;
Review Comment:
Start imports are disallowed and causing the build to fail.
Need to import exact classes required for the build to proceed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Convert multi-assignments to single assignments [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo merged PR #5608:
URL: https://github.com/apache/accumulo/pull/5608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Convert multi-assignments to single assignments [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on PR #5608:
URL: https://github.com/apache/accumulo/pull/5608#issuecomment-2931474325
The build is failing due to unformatted files. If you run `mvn clean package -DskipTests` (`-DskipTests` just skips running the tests), the formatter will run. You'll just need to push a commit with the changes made by the formatter, then the build should pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Convert multi-assignments to single assignments [accumulo]
Posted by "ibilley7 (via GitHub)" <gi...@apache.org>.
ibilley7 commented on code in PR #5608:
URL: https://github.com/apache/accumulo/pull/5608#discussion_r2121805533
##########
core/src/test/java/org/apache/accumulo/core/iterators/user/RegExFilterTest.java:
##########
@@ -248,8 +248,10 @@ public void test1() throws IOException {
public void testNullByteInKey() throws IOException {
TreeMap<Key,Value> tm = new TreeMap<>();
- String s1 = "first", s2 = "second";
- byte[] b1 = s1.getBytes(UTF_8), b2 = s2.getBytes(UTF_8), ball;
+ String s1 = "first";
+ String s2 = "second";
+ byte[] b1 = s1.getBytes(UTF_8);
+ byte[] b2 = s2.getBytes(UTF_8), ball;
Review Comment:
Yes, I'll fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Convert multi-assignments to single assignments [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on PR #5608:
URL: https://github.com/apache/accumulo/pull/5608#issuecomment-2936840484
Thanks for the PR @ibilley7. I see you aren't listed on our "people" page, acknowledging contributors. If you wish to be added as a contributor to https://accumulo.apache.org/people/ , please open a pull request to add yourself at https://github.com/apache/accumulo-website/edit/main/pages/people.md and leave a reference to `apache/accumulo#5608` in your commit log.
If you intend to be a regular contributor to Accumulo projects, please consider subscribing to our developer mailing list (https://accumulo.apache.org/contact-us/) and introducing yourself.
(this message has been mostly copied and pasted from [this comment](https://github.com/apache/accumulo/pull/4192#issuecomment-1933020530))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Convert multi-assignments to single assignments [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on code in PR #5608:
URL: https://github.com/apache/accumulo/pull/5608#discussion_r2121647565
##########
core/src/test/java/org/apache/accumulo/core/iterators/user/RegExFilterTest.java:
##########
@@ -248,8 +248,10 @@ public void test1() throws IOException {
public void testNullByteInKey() throws IOException {
TreeMap<Key,Value> tm = new TreeMap<>();
- String s1 = "first", s2 = "second";
- byte[] b1 = s1.getBytes(UTF_8), b2 = s2.getBytes(UTF_8), ball;
+ String s1 = "first";
+ String s2 = "second";
+ byte[] b1 = s1.getBytes(UTF_8);
+ byte[] b2 = s2.getBytes(UTF_8), ball;
Review Comment:
Is `ball` another `byte[]` that could be broken out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org