You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/10 22:51:37 UTC
[GitHub] [airflow] milton0825 opened a new pull request #9756: Backfill reset_dagruns set DagRun to NONE state
milton0825 opened a new pull request #9756:
URL: https://github.com/apache/airflow/pull/9756
---
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Target Github ISSUE in description if exists
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on pull request #9756: Backfill reset_dagruns set DagRun to NONE state
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #9756:
URL: https://github.com/apache/airflow/pull/9756#issuecomment-656967730
This code looks good 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #9756: Backfill reset_dagruns set DagRun to NONE state
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #9756:
URL: https://github.com/apache/airflow/pull/9756#discussion_r453182785
##########
File path: tests/models/test_dag.py
##########
@@ -1355,6 +1355,56 @@ def test_create_dagrun_run_type_is_obtained_from_run_id(self):
dr = dag.create_dagrun(run_id="custom_is_set_to_manual", state=State.NONE)
assert dr.run_type == DagRunType.MANUAL.value
+ def test_clear_reset_dagruns(self):
+ dag_id = 'test_clear_dag_reset_dagruns'
+ self._clean_up(dag_id)
+ task_id = 't1'
+ dag = DAG(dag_id, start_date=DEFAULT_DATE, max_active_runs=1)
+ t_1 = DummyOperator(task_id=task_id, dag=dag)
+
+ session = settings.Session()
+ dagrun_1 = dag.create_dagrun(
+ run_type=DagRunType.BACKFILL_JOB,
+ state=State.RUNNING,
+ start_date=DEFAULT_DATE,
+ execution_date=DEFAULT_DATE,
+ )
+ session.merge(dagrun_1)
+
+ task_instance_1 = TI(t_1, execution_date=DEFAULT_DATE, state=State.RUNNING)
+ session.merge(task_instance_1)
+ session.commit()
Review comment:
Would you mind using `create_session` ctx manager?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] milton0825 merged pull request #9756: Backfill reset_dagruns set DagRun to NONE state
Posted by GitBox <gi...@apache.org>.
milton0825 merged pull request #9756:
URL: https://github.com/apache/airflow/pull/9756
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org