You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by mt...@apache.org on 2019/10/26 16:24:22 UTC

svn commit: r1869010 - /ofbiz/ofbiz-framework/trunk/build.gradle

Author: mthl
Date: Sat Oct 26 16:24:22 2019
New Revision: 1869010

URL: http://svn.apache.org/viewvc?rev=1869010&view=rev
Log:
Improved: Define specific ‘maxErrors’ for main/test source sets.
(OFBIZ-11262)

Previously a common maximum “checkstyle” error count was provided for
the main/test source sets.  This means that there was no effective
detection of newly introduced coding style errors in tests.  We are
now defining separate error counts to avoid new tests to introduce
such errors.

Thanks: Gil Portenseigne for identifying this limitation.

Modified:
    ofbiz/ofbiz-framework/trunk/build.gradle

Modified: ofbiz/ofbiz-framework/trunk/build.gradle
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/build.gradle?rev=1869010&r1=1869009&r2=1869010&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/build.gradle (original)
+++ ofbiz/ofbiz-framework/trunk/build.gradle Sat Oct 26 16:24:22 2019
@@ -307,7 +307,8 @@ checkstyle {
     // the sum of errors that were present before introducing the
     // ‘checkstyle’ tool present in the framework and in the official
     // plugins.
-    maxErrors = 37864
+    tasks.checkstyleMain.maxErrors = 37858
+    tasks.checkstyleTest.maxErrors = 176
     // Currently there are a lot of errors so we need to temporarily
     // hide them to avoid polluting the terminal output.
     showViolations = false