You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by stigsb <gi...@git.apache.org> on 2014/08/21 21:19:29 UTC

[GitHub] thrift pull request: JavaScript: set Accept: and Content-Type: hea...

GitHub user stigsb opened a pull request:

    https://github.com/apache/thrift/pull/201

    JavaScript: set Accept: and Content-Type: headers in request

    When a JS client communicates with a backend supporting several encodings, knowing which protocol to use is a bit kludgy. This patch tries to fix that by always setting the Accept: and Content-Type: request headers to "application/json".

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stigsb/thrift THRIFT-2674

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/201.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #201
    
----
commit e55fa30b317f5e86af55e12f2e09e13ebb1d49e5
Author: Stig Bakken <st...@zedge.net>
Date:   2014-08-21T19:18:08Z

    JavaScript: set Accept: and Content-Type: headers in request

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: JavaScript: set Accept: and Content-Type: hea...

Posted by jfarrell <gi...@git.apache.org>.

Github user jfarrell closed the pull request at:

    https://github.com/apache/thrift/pull/201


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: JavaScript: set Accept: and Content-Type: hea...

Posted by jfarrell <gi...@git.apache.org>.

Github user jfarrell commented on the pull request:

    https://github.com/apache/thrift/pull/201#issuecomment-93616800
  
    Thanks for your patch @stigsb, in order for us to accept a pull request we need to have a jira ticket associated with it. Please see our contributing guide at http://thrift.apache.org/docs/HowToContribute


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: JavaScript: set Accept: and Content-Type: hea...

Posted by hcorg <gi...@git.apache.org>.

Github user hcorg commented on the pull request:

    https://github.com/apache/thrift/pull/201#issuecomment-57615427
  
    https://issues.apache.org/jira/browse/THRIFT-2674


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---