You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2016/04/19 01:48:23 UTC

Review Request 46352: Add quick links to the hs2 interactive UI on Ambari

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46352/
-----------------------------------------------------------

Review request for Ambari, Srimanth Gunturi and Yusaku Sako.


Bugs: AMBARI-15956
    https://issues.apache.org/jira/browse/AMBARI-15956


Repository: ambari


Description
-------

Add quick links to the hs2 interactive UI on Ambari


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml ba46f00 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/metainfo.xml fcd05a4 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/quicklinks/quicklinks.json PRE-CREATION 
  ambari-web/app/models/quicklinks/quick_links_config.js d7d98e2 
  ambari-web/app/templates/main/dashboard/widgets/hbase_links.hbs 5c686a8 
  ambari-web/app/templates/main/dashboard/widgets/hdfs_links.hbs 83d49b1 
  ambari-web/app/templates/main/dashboard/widgets/yarn_links.hbs b6f1087 
  ambari-web/app/templates/main/service/info/metrics/hive/hive_quick_links.hbs PRE-CREATION 
  ambari-web/app/templates/main/service/item.hbs bc7f05f 
  ambari-web/app/views/common/quick_view_link_view.js 3a99d7a 
  ambari-web/test/views/common/quick_link_view_test.js 2b1c08f 

Diff: https://reviews.apache.org/r/46352/diff/


Testing
-------

#Manually tested the patch to work.

#verfied that all ambari-web unit tests passes:

  25675 tests complete (26 seconds)
  154 tests pending


Thanks,

Jaimin Jetly


Re: Review Request 46352: Add quick links to the hs2 interactive UI on Ambari

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46352/#review129449
-----------------------------------------------------------


Ship it!




Ship It!

- Yusaku Sako


On April 18, 2016, 11:48 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46352/
> -----------------------------------------------------------
> 
> (Updated April 18, 2016, 11:48 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15956
>     https://issues.apache.org/jira/browse/AMBARI-15956
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add quick links to the hs2 interactive UI on Ambari
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml ba46f00 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/metainfo.xml fcd05a4 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/quicklinks/quicklinks.json PRE-CREATION 
>   ambari-web/app/models/quicklinks/quick_links_config.js d7d98e2 
>   ambari-web/app/templates/main/dashboard/widgets/hbase_links.hbs 5c686a8 
>   ambari-web/app/templates/main/dashboard/widgets/hdfs_links.hbs 83d49b1 
>   ambari-web/app/templates/main/dashboard/widgets/yarn_links.hbs b6f1087 
>   ambari-web/app/templates/main/service/info/metrics/hive/hive_quick_links.hbs PRE-CREATION 
>   ambari-web/app/templates/main/service/item.hbs bc7f05f 
>   ambari-web/app/views/common/quick_view_link_view.js 3a99d7a 
>   ambari-web/test/views/common/quick_link_view_test.js 2b1c08f 
> 
> Diff: https://reviews.apache.org/r/46352/diff/
> 
> 
> Testing
> -------
> 
> #Manually tested the patch to work.
> 
> #verfied that all ambari-web unit tests passes:
> 
>   25675 tests complete (26 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>