You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/22 17:57:29 UTC
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10105: fix: Loading overlay bugfix and cleanup
codecov-commenter commented on pull request #10105:
URL: https://github.com/apache/incubator-superset/pull/10105#issuecomment-647683657
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10105?src=pr&el=h1) Report
> Merging [#10105](https://codecov.io/gh/apache/incubator-superset/pull/10105?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/02fee35314258e9af8ed7cef9f2f589aa253ab65&el=desc) will **decrease** coverage by `4.75%`.
> The diff coverage is `38.46%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10105?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10105 +/- ##
==========================================
- Coverage 70.56% 65.80% -4.76%
==========================================
Files 590 590
Lines 31150 31199 +49
Branches 3164 3192 +28
==========================================
- Hits 21981 20532 -1449
- Misses 9060 10486 +1426
- Partials 109 181 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.58% <38.46%> (+0.04%)` | :arrow_up: |
| #python | `70.22% <ø> (+0.03%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10105?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10105/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `82.75% <0.00%> (ø)` | |
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10105/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.41% <0.00%> (-56.25%)` | :arrow_down: |
| [superset-frontend/src/components/Button.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10105/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uLmpzeA==) | `88.88% <ø> (ø)` | |
| [superset-frontend/src/components/Loading.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10105/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy50c3g=) | `44.44% <40.00%> (ø)` | |
| [...et-frontend/src/components/RefreshChartOverlay.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10105/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVmcmVzaENoYXJ0T3ZlcmxheS50c3g=) | `60.00% <60.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10105/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10105/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10105/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10105/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10105/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/10105/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10105?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10105?src=pr&el=footer). Last update [02fee35...5371c75](https://codecov.io/gh/apache/incubator-superset/pull/10105?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org