You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by stacic <gi...@git.apache.org> on 2014/06/03 22:24:31 UTC
[GitHub] cordova-mobile-spec pull request: CB-6855 globalization.spec.37 on...
GitHub user stacic opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/67
CB-6855 globalization.spec.37 on wp8
Fixed tests to reflect that 'pattern' property of NumberFormat is not
supported on wp8 (returns empty string)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stacic/cordova-mobile-spec CB-6855
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-mobile-spec/pull/67.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #67
----
commit 8538380ab2282025e3dab9f0ada97a6dadab6691
Author: Staci Cooper <sm...@us.ibm.com>
Date: 2014-06-03T20:23:19Z
CB-6855 globalization.spec.37 on wp8
Fixed tests to reflect that 'pattern' property of NumberFormat is not
supported on wp8 (returns empty string)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-mobile-spec pull request: CB-6855 globalization.spec.37 on...
Posted by stacic <gi...@git.apache.org>.
Github user stacic closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/67
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-mobile-spec pull request: CB-6855 globalization.spec.37 on...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/67#issuecomment-45017739
I think it is reasonable for this test to fail until it is implemented. Hiding a failing test is not the same as fixing a failing test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-mobile-spec pull request: CB-6855 globalization.spec.37 on...
Posted by stacic <gi...@git.apache.org>.
Github user stacic commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/67#issuecomment-45020219
I agree, but I think there should at least be some distinction between 'broken' and 'not implemented'. There are a lot of failing tests for wp8 right now, and it's not obvious by running mobilespec which ones are actually 'broken'. (And it makes using mobilespec for regression testing more difficult than it needs to be.)
I'll look at implementing pattern and getCurrencyFormat, since that's definitely preferable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---