[GitHub] [doris] yiguolei commented on a diff in pull request #19789: [feature](profile)Add the filtering information of the Bloom filter in profile.

["yiguolei (via GitHub)" <gi...@apache.org>]

yiguolei commented on code in PR #19789:
URL: https://github.com/apache/doris/pull/19789#discussion_r1197481595


##########
be/src/olap/bloom_filter_predicate.h:
##########
@@ -30,15 +30,27 @@
 namespace doris {
 
 // only use in runtime filter and segment v2
+
+class BloomFilterColumnHleper : public ColumnPredicate {
+public:
+    BloomFilterColumnHleper(uint32_t column_id, int id)

Review Comment:
   I think you could find a more common method to do it for all predicate not only for bloomfilter. For example, you could add a get_id() or to_string method to columnpredicate.
   and you could save a map <predicate_id, filterstats> to save the stats for every predicate.
   So if we want to add other filter stats for a new predicate (not bloom filter), it could be more expansible.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org