[GitHub] [incubator-seatunnel] ic4y commented on a diff in pull request #4764: [hotfix][kafka] Fix the problem that the partition information cannot be obtained when kafka is restored

["ic4y (via GitHub)" <gi...@apache.org>]

ic4y commented on code in PR #4764:
URL: https://github.com/apache/incubator-seatunnel/pull/4764#discussion_r1197457591


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceSplitEnumerator.java:
##########
@@ -180,7 +182,6 @@ public void close() throws IOException {
     public void addSplitsBack(List<KafkaSourceSplit> splits, int subtaskId) {
         if (!splits.isEmpty()) {
             pendingSplit.putAll(convertToNextSplit(splits));
-            assignSplit();

Review Comment:
   During runtime, if new partition are discovered, will they not be distributed anymore?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org