You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/27 22:21:49 UTC
[GitHub] larroy commented on a change in pull request #13343: Mitigate
exponential complexity when running gpu_topology tests
larroy commented on a change in pull request #13343: Mitigate exponential complexity when running gpu_topology tests
URL: https://github.com/apache/incubator-mxnet/pull/13343#discussion_r236870705
##########
File path: tests/cpp/kvstore/gpu_topology_test.cc
##########
@@ -71,11 +67,12 @@ void TestComputeTreesRandomized(int num_gpus, float alpha, int backtrack,
bool satisfied = false;
std::vector<float> W(num_gpus*num_gpus, 0.f);
int depth = mxnet::kvstore::ComputeDepth(num_gpus);
- while (!satisfied) {
- float k = dis(*gen);
- std::fill(W.begin(), W.end(), 0.f);
- GenerateMatrix(&W, num_gpus, k, gen);
- satisfied = IsSatisfactory(W, num_gpus, depth);
+ GenerateMatrix(&W, num_gpus, gen);
+ satisfied = IsSatisfactory(W, num_gpus, depth);
+ if (mxnet::kvstore::kLogTree && !satisfied) {
Review comment:
yes, it's of no use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services