You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2024/02/22 00:07:03 UTC
(superset) branch node-18 created (now 0e671841b9)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a change to branch node-18
in repository https://gitbox.apache.org/repos/asf/superset.git
at 0e671841b9 chore(node): bumping Superset to Node 18
This branch includes the following new commits:
new 0e671841b9 chore(node): bumping Superset to Node 18
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(superset) 01/01: chore(node): bumping Superset to Node 18
Posted by ru...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch node-18
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 0e671841b97853110f1d9442adbd74c4b8142373
Author: Evan Rusackas <ev...@rusackas.com>
AuthorDate: Wed Feb 21 17:06:42 2024 -0700
chore(node): bumping Superset to Node 18
---
.github/workflows/embedded-sdk-release.yml | 2 +-
.github/workflows/embedded-sdk-test.yml | 2 +-
.github/workflows/release.yml | 2 +-
.github/workflows/superset-applitool-cypress.yml | 2 +-
.github/workflows/superset-applitools-storybook.yml | 2 +-
.github/workflows/superset-docs-deploy.yml | 4 ++--
.github/workflows/superset-docs-verify.yml | 4 ++--
.github/workflows/superset-frontend.yml | 2 +-
.github/workflows/superset-translations.yml | 2 +-
.github/workflows/tech-debt.yml | 2 +-
.github/workflows/update-monorepo-lockfiles.yml | 2 +-
CONTRIBUTING.md | 4 ++--
Dockerfile | 2 +-
docker-compose.yml | 2 +-
superset-frontend/package-lock.json | 4 ++--
superset-frontend/package.json | 4 ++--
16 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/.github/workflows/embedded-sdk-release.yml b/.github/workflows/embedded-sdk-release.yml
index 39ee461f6b..bdf8bc95f3 100644
--- a/.github/workflows/embedded-sdk-release.yml
+++ b/.github/workflows/embedded-sdk-release.yml
@@ -30,7 +30,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
- node-version: "16"
+ node-version: "18"
registry-url: 'https://registry.npmjs.org'
- run: npm ci
- run: npm run ci:release
diff --git a/.github/workflows/embedded-sdk-test.yml b/.github/workflows/embedded-sdk-test.yml
index cbed118340..e3f3c1bdca 100644
--- a/.github/workflows/embedded-sdk-test.yml
+++ b/.github/workflows/embedded-sdk-test.yml
@@ -21,7 +21,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
- node-version: "16"
+ node-version: "18"
registry-url: 'https://registry.npmjs.org'
- run: npm ci
- run: npm test
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index e504c93b49..f5debddc4a 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -28,7 +28,7 @@ jobs:
strategy:
matrix:
- node-version: [16]
+ node-version: [18]
steps:
- uses: actions/checkout@v4
diff --git a/.github/workflows/superset-applitool-cypress.yml b/.github/workflows/superset-applitool-cypress.yml
index 7341372cad..56a462a76d 100644
--- a/.github/workflows/superset-applitool-cypress.yml
+++ b/.github/workflows/superset-applitool-cypress.yml
@@ -26,7 +26,7 @@ jobs:
fail-fast: false
matrix:
browser: ["chrome"]
- node: [16]
+ node: [18]
env:
SUPERSET_ENV: development
SUPERSET_CONFIG: tests.integration_tests.superset_test_config
diff --git a/.github/workflows/superset-applitools-storybook.yml b/.github/workflows/superset-applitools-storybook.yml
index f0565bb1b0..147d64d286 100644
--- a/.github/workflows/superset-applitools-storybook.yml
+++ b/.github/workflows/superset-applitools-storybook.yml
@@ -30,7 +30,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
- node: [16]
+ node: [18]
steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v4
diff --git a/.github/workflows/superset-docs-deploy.yml b/.github/workflows/superset-docs-deploy.yml
index aa733eba23..a6eefe3644 100644
--- a/.github/workflows/superset-docs-deploy.yml
+++ b/.github/workflows/superset-docs-deploy.yml
@@ -35,10 +35,10 @@ jobs:
with:
persist-credentials: false
submodules: recursive
- - name: Set up Node.js 16
+ - name: Set up Node.js 18
uses: actions/setup-node@v4
with:
- node-version: '16'
+ node-version: '18'
- name: yarn install
run: |
yarn install --check-cache
diff --git a/.github/workflows/superset-docs-verify.yml b/.github/workflows/superset-docs-verify.yml
index 711f17a887..d51b234a16 100644
--- a/.github/workflows/superset-docs-verify.yml
+++ b/.github/workflows/superset-docs-verify.yml
@@ -24,10 +24,10 @@ jobs:
with:
persist-credentials: false
submodules: recursive
- - name: Set up Node.js 16
+ - name: Set up Node.js 18
uses: actions/setup-node@v4
with:
- node-version: '16'
+ node-version: '18'
- name: yarn install
run: |
yarn install --check-cache
diff --git a/.github/workflows/superset-frontend.yml b/.github/workflows/superset-frontend.yml
index 3ac99de33c..25fc768768 100644
--- a/.github/workflows/superset-frontend.yml
+++ b/.github/workflows/superset-frontend.yml
@@ -38,7 +38,7 @@ jobs:
if: steps.check.outcome == 'failure'
uses: actions/setup-node@v4
with:
- node-version: "16"
+ node-version: "18"
- name: Install dependencies
if: steps.check.outcome == 'failure'
uses: ./.github/actions/cached-dependencies
diff --git a/.github/workflows/superset-translations.yml b/.github/workflows/superset-translations.yml
index 647e27b3d7..a9c3b517f7 100644
--- a/.github/workflows/superset-translations.yml
+++ b/.github/workflows/superset-translations.yml
@@ -24,7 +24,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
- node-version: '16'
+ node-version: '18'
- name: Install dependencies
uses: ./.github/actions/cached-dependencies
with:
diff --git a/.github/workflows/tech-debt.yml b/.github/workflows/tech-debt.yml
index ccbf0ba181..c35c5a9c57 100644
--- a/.github/workflows/tech-debt.yml
+++ b/.github/workflows/tech-debt.yml
@@ -31,7 +31,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
- node-version: '16'
+ node-version: '18'
- name: Install Dependencies
run: npm install
diff --git a/.github/workflows/update-monorepo-lockfiles.yml b/.github/workflows/update-monorepo-lockfiles.yml
index 2ecabdfd39..4281e79d49 100644
--- a/.github/workflows/update-monorepo-lockfiles.yml
+++ b/.github/workflows/update-monorepo-lockfiles.yml
@@ -32,7 +32,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
- node-version: '16'
+ node-version: '18'
- name: Install Dependencies and Update Lock File
run: |
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 4afa69eb2e..ceeb9bd769 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -584,8 +584,8 @@ Frontend assets (TypeScript, JavaScript, CSS, and images) must be compiled in or
First, be sure you are using the following versions of Node.js and npm:
-- `Node.js`: Version 16
-- `npm`: Version 7
+- `Node.js`: Version 18
+- `npm`: Version 10
We recommend using [nvm](https://github.com/nvm-sh/nvm) to manage your node environment:
diff --git a/Dockerfile b/Dockerfile
index fc3e667037..9e03fec91f 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -22,7 +22,7 @@ ARG PY_VER=3.9-slim-bookworm
# if BUILDPLATFORM is null, set it to 'amd64' (or leave as is otherwise).
ARG BUILDPLATFORM=${BUILDPLATFORM:-amd64}
-FROM --platform=${BUILDPLATFORM} node:16-bookworm-slim AS superset-node
+FROM --platform=${BUILDPLATFORM} node:18-bullseye-slim AS superset-node
ARG NPM_BUILD_CMD="build"
diff --git a/docker-compose.yml b/docker-compose.yml
index a2dfc26dba..8df4a05762 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -119,7 +119,7 @@ services:
disable: true
superset-node:
- image: node:16
+ image: node:18
container_name: superset_node
command: ["/app/docker/docker-frontend.sh"]
env_file: docker/.env
diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json
index 101451f097..df9e7d3056 100644
--- a/superset-frontend/package-lock.json
+++ b/superset-frontend/package-lock.json
@@ -288,8 +288,8 @@
"xdm": "^3.4.0"
},
"engines": {
- "node": "^16.20.2",
- "npm": "^8.19.4"
+ "node": "^18.19.1",
+ "npm": "^10.2.4"
}
},
"buildtools/eslint-plugin-theme-colors": {
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
index 8f792d06a0..26b71166b7 100644
--- a/superset-frontend/package.json
+++ b/superset-frontend/package.json
@@ -356,8 +356,8 @@
"xdm": "^3.4.0"
},
"engines": {
- "node": "^16.20.2",
- "npm": "^8.19.4"
+ "node": "^18.19.1",
+ "npm": "^10.2.4"
},
"overrides": {
"d3-color": "^3.1.0",