You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by co...@apache.org on 2015/10/21 07:33:44 UTC
incubator-zeppelin git commit: ZEPPELIN-351 - Can't remove elems in
pivot
Repository: incubator-zeppelin
Updated Branches:
refs/heads/master e362042ff -> 0748b4d8a
ZEPPELIN-351 - Can't remove elems in pivot
Fix ZEPPELIN-351, On Firefox, we couldn't remove pivot elements from groups and keys.
Click event wasn't going through the `button` container, so I changed container to `div`
Author: Damien CORNEAU <co...@gmail.com>
Closes #353 from corneadoug/fix/ZEPPELIN-351 and squashes the following commits:
86f16fb [Damien CORNEAU] Replace button by div in pivot settings
Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/0748b4d8
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/0748b4d8
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/0748b4d8
Branch: refs/heads/master
Commit: 0748b4d8a98f42f3f85a73a22a51c264462f66c2
Parents: e362042
Author: Damien CORNEAU <co...@gmail.com>
Authored: Tue Oct 20 12:02:13 2015 +0900
Committer: Damien CORNEAU <co...@gmail.com>
Committed: Wed Oct 21 14:33:28 2015 +0900
----------------------------------------------------------------------
zeppelin-web/src/app/notebook/paragraph/paragraph.html | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/0748b4d8/zeppelin-web/src/app/notebook/paragraph/paragraph.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.html b/zeppelin-web/src/app/notebook/paragraph/paragraph.html
index 8079b21..4324f34 100644
--- a/zeppelin-web/src/app/notebook/paragraph/paragraph.html
+++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.html
@@ -186,9 +186,9 @@ limitations under the License.
jqyoui-droppable="{multiple:true, onDrop:'onGraphOptionChange()'}"
class="list-unstyled">
<li ng-repeat="item in paragraph.config.graph.keys">
- <button class="btn btn-primary btn-xs">
+ <div class="btn btn-primary btn-xs">
{{item.name}} <span class="fa fa-close" ng-click="removeGraphOptionKeys($index)"></span>
- </button>
+ </div>
</li>
</ul>
</span>
@@ -201,9 +201,9 @@ limitations under the License.
jqyoui-droppable="{multiple:true, onDrop:'onGraphOptionChange()'}"
class="list-unstyled">
<li ng-repeat="item in paragraph.config.graph.groups">
- <button class="btn btn-success btn-xs">
+ <div class="btn btn-success btn-xs">
{{item.name}} <span class="fa fa-close" ng-click="removeGraphOptionGroups($index)"></span>
- </button>
+ </div>
</li>
</ul>
</span>