You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "David Mollitor (Jira)" <ji...@apache.org> on 2021/07/07 17:06:00 UTC

[jira] [Updated] (ORC-837) Reuse HiveDecimalWritable in ConvertTreeReaderFactory

     [ https://issues.apache.org/jira/browse/ORC-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Mollitor updated ORC-837:
-------------------------------
    Description: 
https://github.com/apache/orc/blob/fb0ed31f15d9b77b76bc5dec8721f5d9ee129879/java/core/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java#L826

Several places in {{ConvertTreeReaderFactory}} that creates a HiveDecimalWritable for each element being processed.  It is very common practice to keep a single instance of {{xyzWritable}} for re-use.  Do the same here.

  was:
https://github.com/apache/orc/blob/fb0ed31f15d9b77b76bc5dec8721f5d9ee129879/java/core/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java#L826

Several places in {{ConvertTreeReaderFactory}} that creates a HiveDecimalWritable for each element being processed.  It is very common practice to keep a single instance of {{xyzWritable }} for re-use.  Do the same here.


> Reuse HiveDecimalWritable in ConvertTreeReaderFactory
> -----------------------------------------------------
>
>                 Key: ORC-837
>                 URL: https://issues.apache.org/jira/browse/ORC-837
>             Project: ORC
>          Issue Type: Improvement
>          Components: Java
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>
> https://github.com/apache/orc/blob/fb0ed31f15d9b77b76bc5dec8721f5d9ee129879/java/core/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java#L826
> Several places in {{ConvertTreeReaderFactory}} that creates a HiveDecimalWritable for each element being processed.  It is very common practice to keep a single instance of {{xyzWritable}} for re-use.  Do the same here.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)