You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Gordon Sim <gs...@redhat.com> on 2014/11/07 19:06:08 UTC
Review Request 27734: Add safe version of QPID_LOG macro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27734/
-----------------------------------------------------------
Review request for qpid, Alan Conway, Andrew Stitcher, and Steve Huston.
Repository: qpid
Description
-------
For use in contexts where exceptions cannot be thrown, add a wrapped version of QPID_LOG that catches any exception.
Diffs
-----
trunk/qpid/cpp/src/qpid/broker/DtxAck.cpp 1637402
trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1637402
trunk/qpid/cpp/src/qpid/broker/TxAccept.cpp 1637402
trunk/qpid/cpp/src/qpid/broker/TxDequeue.cpp 1637402
trunk/qpid/cpp/src/qpid/log/Statement.h 1637402
Diff: https://reviews.apache.org/r/27734/diff/
Testing
-------
Thanks,
Gordon Sim
Re: Review Request 27734: Add safe version of QPID_LOG macro
Posted by Alan Conway <ac...@redhat.com>.
> On Nov. 7, 2014, 6:10 p.m., Andrew Stitcher wrote:
> > trunk/qpid/cpp/src/qpid/log/Statement.h, line 219
> > <https://reviews.apache.org/r/27734/diff/1/?file=754603#file754603line219>
> >
> > It might be better to investigate a little bit more what can cause QPID_LOG to throw an exception and to mitigate it or catch it closer to the source.
QPID_LOG should _never_ throw. It is routineline going to be used in places (destructors, error handling etc.) where throwing a new exception will really, really not be helpful. So 2 things:
1. What andrew said
2. Don't add QPID_LOG_NOTHROW - add the catch logic to QPID_LOG itself.
- Alan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27734/#review60354
-----------------------------------------------------------
On Nov. 7, 2014, 6:06 p.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27734/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 6:06 p.m.)
>
>
> Review request for qpid, Alan Conway, Andrew Stitcher, and Steve Huston.
>
>
> Repository: qpid
>
>
> Description
> -------
>
> For use in contexts where exceptions cannot be thrown, add a wrapped version of QPID_LOG that catches any exception.
>
>
> Diffs
> -----
>
> trunk/qpid/cpp/src/qpid/broker/DtxAck.cpp 1637402
> trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1637402
> trunk/qpid/cpp/src/qpid/broker/TxAccept.cpp 1637402
> trunk/qpid/cpp/src/qpid/broker/TxDequeue.cpp 1637402
> trunk/qpid/cpp/src/qpid/log/Statement.h 1637402
>
> Diff: https://reviews.apache.org/r/27734/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request 27734: Add safe version of QPID_LOG macro
Posted by Andrew Stitcher <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27734/#review60354
-----------------------------------------------------------
trunk/qpid/cpp/src/qpid/log/Statement.h
<https://reviews.apache.org/r/27734/#comment101716>
It might be better to investigate a little bit more what can cause QPID_LOG to throw an exception and to mitigate it or catch it closer to the source.
- Andrew Stitcher
On Nov. 7, 2014, 6:06 p.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27734/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 6:06 p.m.)
>
>
> Review request for qpid, Alan Conway, Andrew Stitcher, and Steve Huston.
>
>
> Repository: qpid
>
>
> Description
> -------
>
> For use in contexts where exceptions cannot be thrown, add a wrapped version of QPID_LOG that catches any exception.
>
>
> Diffs
> -----
>
> trunk/qpid/cpp/src/qpid/broker/DtxAck.cpp 1637402
> trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1637402
> trunk/qpid/cpp/src/qpid/broker/TxAccept.cpp 1637402
> trunk/qpid/cpp/src/qpid/broker/TxDequeue.cpp 1637402
> trunk/qpid/cpp/src/qpid/log/Statement.h 1637402
>
> Diff: https://reviews.apache.org/r/27734/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gordon Sim
>
>