You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/03/03 09:07:59 UTC
[jira] [Commented] (BOOKKEEPER-160) bookie server needs to do
compaction over entry log files to reclaim disk space
[ https://issues.apache.org/jira/browse/BOOKKEEPER-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221540#comment-13221540 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-160:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3874/
-----------------------------------------------------------
(Updated 2012-03-03 08:07:49.773622)
Review request for bookkeeper.
Changes
-------
attach a new patch addressed Ivan's comment to separate minor & major compaction into different threshold and interval to make them clearly.
Summary
-------
bookie server aggregates entries into entry log file. suppose there is lots of ledgers, each ledger has little messages. so a entry log file would contains messages from lots of different ledgers. if there is only one ledger not be deleted, the entry log file would not be removed, whose occupied disk space could not be reclaimed.
This addresses bug BOOKKEEPER-160.
https://issues.apache.org/jira/browse/BOOKKEEPER-160
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java 23a1ffc
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CompactionTest.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java f661e90
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java aca66e6
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 51195d4
bookkeeper-server/conf/bk_server.conf d005d01
Diff: https://reviews.apache.org/r/3874/diff
Testing
-------
Thanks,
Sijie
> bookie server needs to do compaction over entry log files to reclaim disk space
> -------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-160
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-160
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.1.0
>
> Attachments: BK-160.patch, BK-160.patch_v2
>
>
> bookie server aggregates entries into entry log file. suppose there is lots of ledgers, each ledger has little messages. so a entry log file would contains messages from lots of different ledgers. if there is only one ledger not be deleted, the entry log file would not be removed, whose occupied disk space could not be reclaimed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira