You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Riccardo (JIRA)" <ji...@apache.org> on 2007/11/09 00:12:50 UTC

[jira] Created: (HADOOP-2174) distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid

distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid
---------------------------------------------------------------------------------------------------------------

                 Key: HADOOP-2174
                 URL: https://issues.apache.org/jira/browse/HADOOP-2174
             Project: Hadoop
          Issue Type: Bug
          Components: util
    Affects Versions: 0.15.0
            Reporter: Riccardo
            Priority: Critical
             Fix For: 0.15.1


distcp occasionally throws a NullPointerException in the close() method of the mapper class, when the copy of the Reporter handle becomes invalid:

java.lang.NullPointerException
       at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.updateStatus(CopyFiles.java:242)
       at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.close(CopyFiles.java:402)
       at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:53)
       at org.apache.hadoop.mapred.MapTask.run(MapTask.java:192)
       at org.apache.hadoop.mapred.TaskTracker$Child.main(TaskTracker.java:1760)

This can easily be fixed by checking whether the Reporter is null before updating the status. Also, the status could be updated once the invocation of copy(srcstat, dstpath, out, reporter); returns on line 373 of CopyFiles.java. Marking this as critical for a 0.15.1 release as Chris requested.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2174) distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541541 ] 

Hudson commented on HADOOP-2174:
--------------------------------

Integrated in Hadoop-Nightly #299 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/299/])

> distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2174
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2174
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.15.0
>            Reporter: Riccardo
>            Assignee: Chris Douglas
>            Priority: Critical
>             Fix For: 0.15.1
>
>         Attachments: 2174-1.patch
>
>
> distcp occasionally throws a NullPointerException in the close() method of the mapper class, when the copy of the Reporter handle becomes invalid:
> java.lang.NullPointerException
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.updateStatus(CopyFiles.java:242)
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.close(CopyFiles.java:402)
>        at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:53)
>        at org.apache.hadoop.mapred.MapTask.run(MapTask.java:192)
>        at org.apache.hadoop.mapred.TaskTracker$Child.main(TaskTracker.java:1760)
> This can easily be fixed by checking whether the Reporter is null before updating the status. Also, the status could be updated once the invocation of copy(srcstat, dstpath, out, reporter); returns on line 373 of CopyFiles.java. Marking this as critical for a 0.15.1 release as Chris requested.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2174) distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-2174:
----------------------------------

    Attachment: 2174.patch

Added a null check in close()

> distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2174
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2174
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.15.0
>            Reporter: Riccardo
>            Priority: Critical
>             Fix For: 0.15.1
>
>         Attachments: 2174.patch
>
>
> distcp occasionally throws a NullPointerException in the close() method of the mapper class, when the copy of the Reporter handle becomes invalid:
> java.lang.NullPointerException
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.updateStatus(CopyFiles.java:242)
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.close(CopyFiles.java:402)
>        at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:53)
>        at org.apache.hadoop.mapred.MapTask.run(MapTask.java:192)
>        at org.apache.hadoop.mapred.TaskTracker$Child.main(TaskTracker.java:1760)
> This can easily be fixed by checking whether the Reporter is null before updating the status. Also, the status could be updated once the invocation of copy(srcstat, dstpath, out, reporter); returns on line 373 of CopyFiles.java. Marking this as critical for a 0.15.1 release as Chris requested.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2174) distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-2174:
----------------------------------

    Status: Patch Available  (was: Open)

> distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2174
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2174
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.15.0
>            Reporter: Riccardo
>            Priority: Critical
>             Fix For: 0.15.1
>
>         Attachments: 2174-1.patch
>
>
> distcp occasionally throws a NullPointerException in the close() method of the mapper class, when the copy of the Reporter handle becomes invalid:
> java.lang.NullPointerException
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.updateStatus(CopyFiles.java:242)
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.close(CopyFiles.java:402)
>        at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:53)
>        at org.apache.hadoop.mapred.MapTask.run(MapTask.java:192)
>        at org.apache.hadoop.mapred.TaskTracker$Child.main(TaskTracker.java:1760)
> This can easily be fixed by checking whether the Reporter is null before updating the status. Also, the status could be updated once the invocation of copy(srcstat, dstpath, out, reporter); returns on line 373 of CopyFiles.java. Marking this as critical for a 0.15.1 release as Chris requested.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-2174) distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy reassigned HADOOP-2174:
-------------------------------------

    Assignee: Chris Douglas

> distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2174
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2174
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.15.0
>            Reporter: Riccardo
>            Assignee: Chris Douglas
>            Priority: Critical
>             Fix For: 0.15.1
>
>         Attachments: 2174-1.patch
>
>
> distcp occasionally throws a NullPointerException in the close() method of the mapper class, when the copy of the Reporter handle becomes invalid:
> java.lang.NullPointerException
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.updateStatus(CopyFiles.java:242)
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.close(CopyFiles.java:402)
>        at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:53)
>        at org.apache.hadoop.mapred.MapTask.run(MapTask.java:192)
>        at org.apache.hadoop.mapred.TaskTracker$Child.main(TaskTracker.java:1760)
> This can easily be fixed by checking whether the Reporter is null before updating the status. Also, the status could be updated once the invocation of copy(srcstat, dstpath, out, reporter); returns on line 373 of CopyFiles.java. Marking this as critical for a 0.15.1 release as Chris requested.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2174) distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-2174:
----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Chris!

> distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2174
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2174
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.15.0
>            Reporter: Riccardo
>            Assignee: Chris Douglas
>            Priority: Critical
>             Fix For: 0.15.1
>
>         Attachments: 2174-1.patch
>
>
> distcp occasionally throws a NullPointerException in the close() method of the mapper class, when the copy of the Reporter handle becomes invalid:
> java.lang.NullPointerException
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.updateStatus(CopyFiles.java:242)
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.close(CopyFiles.java:402)
>        at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:53)
>        at org.apache.hadoop.mapred.MapTask.run(MapTask.java:192)
>        at org.apache.hadoop.mapred.TaskTracker$Child.main(TaskTracker.java:1760)
> This can easily be fixed by checking whether the Reporter is null before updating the status. Also, the status could be updated once the invocation of copy(srcstat, dstpath, out, reporter); returns on line 373 of CopyFiles.java. Marking this as critical for a 0.15.1 release as Chris requested.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2174) distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-2174:
----------------------------------

    Status: Patch Available  (was: Open)

> distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2174
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2174
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.15.0
>            Reporter: Riccardo
>            Priority: Critical
>             Fix For: 0.15.1
>
>         Attachments: 2174.patch
>
>
> distcp occasionally throws a NullPointerException in the close() method of the mapper class, when the copy of the Reporter handle becomes invalid:
> java.lang.NullPointerException
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.updateStatus(CopyFiles.java:242)
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.close(CopyFiles.java:402)
>        at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:53)
>        at org.apache.hadoop.mapred.MapTask.run(MapTask.java:192)
>        at org.apache.hadoop.mapred.TaskTracker$Child.main(TaskTracker.java:1760)
> This can easily be fixed by checking whether the Reporter is null before updating the status. Also, the status could be updated once the invocation of copy(srcstat, dstpath, out, reporter); returns on line 373 of CopyFiles.java. Marking this as critical for a 0.15.1 release as Chris requested.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2174) distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-2174:
----------------------------------

    Attachment: 2174-1.patch

> distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2174
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2174
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.15.0
>            Reporter: Riccardo
>            Priority: Critical
>             Fix For: 0.15.1
>
>         Attachments: 2174-1.patch
>
>
> distcp occasionally throws a NullPointerException in the close() method of the mapper class, when the copy of the Reporter handle becomes invalid:
> java.lang.NullPointerException
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.updateStatus(CopyFiles.java:242)
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.close(CopyFiles.java:402)
>        at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:53)
>        at org.apache.hadoop.mapred.MapTask.run(MapTask.java:192)
>        at org.apache.hadoop.mapred.TaskTracker$Child.main(TaskTracker.java:1760)
> This can easily be fixed by checking whether the Reporter is null before updating the status. Also, the status could be updated once the invocation of copy(srcstat, dstpath, out, reporter); returns on line 373 of CopyFiles.java. Marking this as critical for a 0.15.1 release as Chris requested.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2174) distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-2174:
----------------------------------

    Status: Open  (was: Patch Available)

On second thought, that's a pretty lame fix. The reporter isn't even necessary in close(); Riccardo's suggestion is the better fix.

> distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2174
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2174
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.15.0
>            Reporter: Riccardo
>            Priority: Critical
>             Fix For: 0.15.1
>
>         Attachments: 2174-1.patch
>
>
> distcp occasionally throws a NullPointerException in the close() method of the mapper class, when the copy of the Reporter handle becomes invalid:
> java.lang.NullPointerException
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.updateStatus(CopyFiles.java:242)
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.close(CopyFiles.java:402)
>        at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:53)
>        at org.apache.hadoop.mapred.MapTask.run(MapTask.java:192)
>        at org.apache.hadoop.mapred.TaskTracker$Child.main(TaskTracker.java:1760)
> This can easily be fixed by checking whether the Reporter is null before updating the status. Also, the status could be updated once the invocation of copy(srcstat, dstpath, out, reporter); returns on line 373 of CopyFiles.java. Marking this as critical for a 0.15.1 release as Chris requested.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2174) distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541197 ] 

Hadoop QA commented on HADOOP-2174:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12369203/2174.patch
against trunk revision r592860.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests -1.  The patch failed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1076/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1076/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1076/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1076/console

This message is automatically generated.

> distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2174
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2174
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.15.0
>            Reporter: Riccardo
>            Priority: Critical
>             Fix For: 0.15.1
>
>         Attachments: 2174-1.patch
>
>
> distcp occasionally throws a NullPointerException in the close() method of the mapper class, when the copy of the Reporter handle becomes invalid:
> java.lang.NullPointerException
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.updateStatus(CopyFiles.java:242)
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.close(CopyFiles.java:402)
>        at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:53)
>        at org.apache.hadoop.mapred.MapTask.run(MapTask.java:192)
>        at org.apache.hadoop.mapred.TaskTracker$Child.main(TaskTracker.java:1760)
> This can easily be fixed by checking whether the Reporter is null before updating the status. Also, the status could be updated once the invocation of copy(srcstat, dstpath, out, reporter); returns on line 373 of CopyFiles.java. Marking this as critical for a 0.15.1 release as Chris requested.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2174) distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-2174:
----------------------------------

    Status: Open  (was: Patch Available)

> distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2174
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2174
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.15.0
>            Reporter: Riccardo
>            Priority: Critical
>             Fix For: 0.15.1
>
>         Attachments: 2174-1.patch
>
>
> distcp occasionally throws a NullPointerException in the close() method of the mapper class, when the copy of the Reporter handle becomes invalid:
> java.lang.NullPointerException
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.updateStatus(CopyFiles.java:242)
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.close(CopyFiles.java:402)
>        at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:53)
>        at org.apache.hadoop.mapred.MapTask.run(MapTask.java:192)
>        at org.apache.hadoop.mapred.TaskTracker$Child.main(TaskTracker.java:1760)
> This can easily be fixed by checking whether the Reporter is null before updating the status. Also, the status could be updated once the invocation of copy(srcstat, dstpath, out, reporter); returns on line 373 of CopyFiles.java. Marking this as critical for a 0.15.1 release as Chris requested.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2174) distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-2174:
----------------------------------

    Attachment:     (was: 2174.patch)

> distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2174
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2174
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.15.0
>            Reporter: Riccardo
>            Priority: Critical
>             Fix For: 0.15.1
>
>         Attachments: 2174-1.patch
>
>
> distcp occasionally throws a NullPointerException in the close() method of the mapper class, when the copy of the Reporter handle becomes invalid:
> java.lang.NullPointerException
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.updateStatus(CopyFiles.java:242)
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.close(CopyFiles.java:402)
>        at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:53)
>        at org.apache.hadoop.mapred.MapTask.run(MapTask.java:192)
>        at org.apache.hadoop.mapred.TaskTracker$Child.main(TaskTracker.java:1760)
> This can easily be fixed by checking whether the Reporter is null before updating the status. Also, the status could be updated once the invocation of copy(srcstat, dstpath, out, reporter); returns on line 373 of CopyFiles.java. Marking this as critical for a 0.15.1 release as Chris requested.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2174) distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-2174:
----------------------------------

    Status: Patch Available  (was: Open)

Timeout in TestBlockReplacement; trying again.

> distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2174
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2174
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.15.0
>            Reporter: Riccardo
>            Priority: Critical
>             Fix For: 0.15.1
>
>         Attachments: 2174-1.patch
>
>
> distcp occasionally throws a NullPointerException in the close() method of the mapper class, when the copy of the Reporter handle becomes invalid:
> java.lang.NullPointerException
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.updateStatus(CopyFiles.java:242)
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.close(CopyFiles.java:402)
>        at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:53)
>        at org.apache.hadoop.mapred.MapTask.run(MapTask.java:192)
>        at org.apache.hadoop.mapred.TaskTracker$Child.main(TaskTracker.java:1760)
> This can easily be fixed by checking whether the Reporter is null before updating the status. Also, the status could be updated once the invocation of copy(srcstat, dstpath, out, reporter); returns on line 373 of CopyFiles.java. Marking this as critical for a 0.15.1 release as Chris requested.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2174) distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541229 ] 

Hadoop QA commented on HADOOP-2174:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12369205/2174-1.patch
against trunk revision r592860.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1078/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1078/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1078/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1078/console

This message is automatically generated.

> distcp throws a NullPointerException in the close() method of mapper class due to the Reporter becoming invalid
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2174
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2174
>             Project: Hadoop
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.15.0
>            Reporter: Riccardo
>            Priority: Critical
>             Fix For: 0.15.1
>
>         Attachments: 2174-1.patch
>
>
> distcp occasionally throws a NullPointerException in the close() method of the mapper class, when the copy of the Reporter handle becomes invalid:
> java.lang.NullPointerException
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.updateStatus(CopyFiles.java:242)
>        at org.apache.hadoop.util.CopyFiles$FSCopyFilesMapper.close(CopyFiles.java:402)
>        at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:53)
>        at org.apache.hadoop.mapred.MapTask.run(MapTask.java:192)
>        at org.apache.hadoop.mapred.TaskTracker$Child.main(TaskTracker.java:1760)
> This can easily be fixed by checking whether the Reporter is null before updating the status. Also, the status could be updated once the invocation of copy(srcstat, dstpath, out, reporter); returns on line 373 of CopyFiles.java. Marking this as critical for a 0.15.1 release as Chris requested.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.