You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergio Pena <se...@cloudera.com> on 2017/07/21 16:38:04 UTC
Review Request 61041: HIVE-17150: CREATE INDEX execute HMS
out-of-transaction listener calls inside a transaction
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61041/
-----------------------------------------------------------
Review request for hive, Alexander Kolbasov, Mohit Sabharwal, and Vihang Karajgaonkar.
Bugs: HIVE-17150
https://issues.apache.org/jira/browse/HIVE-17150
Repository: hive-git
Description
-------
The patch adds a new parameter, HIVE_METASTORE_TRANSACTION_ACTIVE, to the parameters passed to the notification listeners. This parameter has a true/false value dependinf if the HMS is running in a transaction or not.
Diffs
-----
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java 6d7ee4cb824ba40537876bd0629831a19ac91d76
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/MetaStoreEventListenerConstants.java a4f2d592ced6427a05177e67be27286c408744a6
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java b016920fa57501b9f07f1810b2f8010e40575efd
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58b9044930046758a83ee499692e5593cd82f9e0
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListenerNotifier.java 20011ccec83e87a55de7668b86773bb817135cbd
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 8f6af9f346102359c3cd1a6c27000f46e1ddbae6
metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 3ac4fe1604c7b0b455894b8e6293484e9226836e
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 5a45051f4417352f20334319c796dc0ca2d8ad9e
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java bd33c7101f5bc01a482153f810b65b620a061636
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 94cbd5235dce0b49b92203ff92d0d2e29e8b2ca9
Diff: https://reviews.apache.org/r/61041/diff/1/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 61041: HIVE-17150: CREATE INDEX execute HMS
out-of-transaction listener calls inside a transaction
Posted by Vihang Karajgaonkar <vi...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61041/#review181268
-----------------------------------------------------------
Ship it!
Ship It!
- Vihang Karajgaonkar
On July 21, 2017, 5:51 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61041/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 5:51 p.m.)
>
>
> Review request for hive, Alexander Kolbasov, Mohit Sabharwal, and Vihang Karajgaonkar.
>
>
> Bugs: HIVE-17150
> https://issues.apache.org/jira/browse/HIVE-17150
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> The patch adds a new parameter, HIVE_METASTORE_TRANSACTION_ACTIVE, to the parameters passed to the notification listeners. This parameter has a true/false value dependinf if the HMS is running in a transaction or not.
>
>
> Diffs
> -----
>
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java 6d7ee4cb824ba40537876bd0629831a19ac91d76
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/MetaStoreEventListenerConstants.java a4f2d592ced6427a05177e67be27286c408744a6
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java b016920fa57501b9f07f1810b2f8010e40575efd
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java 808c9c7c36fd0ba36adac7be942c4841ab0a08a8
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58b9044930046758a83ee499692e5593cd82f9e0
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListenerNotifier.java 20011ccec83e87a55de7668b86773bb817135cbd
> metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 8f6af9f346102359c3cd1a6c27000f46e1ddbae6
> metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 3ac4fe1604c7b0b455894b8e6293484e9226836e
> metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 5a45051f4417352f20334319c796dc0ca2d8ad9e
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java bd33c7101f5bc01a482153f810b65b620a061636
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 94cbd5235dce0b49b92203ff92d0d2e29e8b2ca9
>
>
> Diff: https://reviews.apache.org/r/61041/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 61041: HIVE-17150: CREATE INDEX execute HMS
out-of-transaction listener calls inside a transaction
Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61041/
-----------------------------------------------------------
(Updated July 21, 2017, 5:51 p.m.)
Review request for hive, Alexander Kolbasov, Mohit Sabharwal, and Vihang Karajgaonkar.
Changes
-------
Fixing HiveQA tests.
Bugs: HIVE-17150
https://issues.apache.org/jira/browse/HIVE-17150
Repository: hive-git
Description
-------
The patch adds a new parameter, HIVE_METASTORE_TRANSACTION_ACTIVE, to the parameters passed to the notification listeners. This parameter has a true/false value dependinf if the HMS is running in a transaction or not.
Diffs (updated)
-----
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java 6d7ee4cb824ba40537876bd0629831a19ac91d76
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/MetaStoreEventListenerConstants.java a4f2d592ced6427a05177e67be27286c408744a6
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java b016920fa57501b9f07f1810b2f8010e40575efd
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java 808c9c7c36fd0ba36adac7be942c4841ab0a08a8
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58b9044930046758a83ee499692e5593cd82f9e0
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListenerNotifier.java 20011ccec83e87a55de7668b86773bb817135cbd
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 8f6af9f346102359c3cd1a6c27000f46e1ddbae6
metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 3ac4fe1604c7b0b455894b8e6293484e9226836e
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 5a45051f4417352f20334319c796dc0ca2d8ad9e
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java bd33c7101f5bc01a482153f810b65b620a061636
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 94cbd5235dce0b49b92203ff92d0d2e29e8b2ca9
Diff: https://reviews.apache.org/r/61041/diff/2/
Changes: https://reviews.apache.org/r/61041/diff/1-2/
Testing
-------
Thanks,
Sergio Pena