You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sahil Takiar (Code Review)" <ge...@cloudera.org> on 2019/11/24 23:08:35 UTC
[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14792
Change subject: IMPALA-9188: Composite primary keys should use same constraint name
......................................................................
IMPALA-9188: Composite primary keys should use same constraint name
After IMPALA-9104, dataload started failing when USE_CDP_HIVE=true
because of HIVE-16603 (Enforce foreign keys to refer to primary keys or
unique keys), which is in Hive 3 but not Hive 2.
This patch fixes a bug from IMPALA-2112 where Impala was generating a
unique constraint name for each column in a composite primary key,
rather than using the same constraint name for each column.
Testing:
* Ran dataload + core tests with USE_CDP_HIVE=[true/false]
Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
---
M fe/src/main/java/org/apache/impala/analysis/TableDef.java
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/14792/1
--
To view, visit http://gerrit.cloudera.org:8080/14792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
Gerrit-Change-Number: 14792
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14792 )
Change subject: IMPALA-9188: Composite primary keys should use same constraint name
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5286/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
Gerrit-Change-Number: 14792
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 17:56:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14792 )
Change subject: IMPALA-9188: Composite primary keys should use same constraint name
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5288/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
Gerrit-Change-Number: 14792
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 18:47:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Hello Anurag Mantripragada, Vihang Karajgaonkar, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14792
to look at the new patch set (#2).
Change subject: IMPALA-9188: Composite primary keys should use same constraint name
......................................................................
IMPALA-9188: Composite primary keys should use same constraint name
After IMPALA-9104, dataload started failing when USE_CDP_HIVE=true
because of HIVE-16603 (Enforce foreign keys to refer to primary keys or
unique keys), which is in Hive 3 but not Hive 2.
This patch fixes a bug from IMPALA-2112 where Impala was generating a
unique constraint name for each column in a composite primary key,
rather than using the same constraint name for each column.
Testing:
* Ran dataload + core tests with USE_CDP_HIVE=[true/false]
Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
---
M fe/src/main/java/org/apache/impala/analysis/TableDef.java
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/14792/2
--
To view, visit http://gerrit.cloudera.org:8080/14792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
Gerrit-Change-Number: 14792
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14792 )
Change subject: IMPALA-9188: Composite primary keys should use same constraint name
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5131/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
Gerrit-Change-Number: 14792
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 18:40:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14792 )
Change subject: IMPALA-9188: Composite primary keys should use same constraint name
......................................................................
Patch Set 1: Code-Review+2
Change looks good to me. Thanks for fixing this.
--
To view, visit http://gerrit.cloudera.org:8080/14792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
Gerrit-Change-Number: 14792
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 17:43:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14792 )
Change subject: IMPALA-9188: Composite primary keys should use same constraint name
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5127/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
Gerrit-Change-Number: 14792
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Nov 2019 23:53:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14792 )
Change subject: IMPALA-9188: Composite primary keys should use same constraint name
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14792/2/fe/src/main/java/org/apache/impala/analysis/TableDef.java
File fe/src/main/java/org/apache/impala/analysis/TableDef.java:
http://gerrit.cloudera.org:8080/#/c/14792/2/fe/src/main/java/org/apache/impala/analysis/TableDef.java@498
PS2, Line 498: // All primary keys in a composite key should have the same constraint name. This is
line too long (92 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/14792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
Gerrit-Change-Number: 14792
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 17:56:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14792 )
Change subject: IMPALA-9188: Composite primary keys should use same constraint name
......................................................................
Patch Set 1: Code-Review+1
Thanks for fixing this. Looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/14792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
Gerrit-Change-Number: 14792
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Nov 2019 23:35:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14792 )
Change subject: IMPALA-9188: Composite primary keys should use same constraint name
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
Gerrit-Change-Number: 14792
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 23:57:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14792 )
Change subject: IMPALA-9188: Composite primary keys should use same constraint name
......................................................................
Patch Set 3: Code-Review+2
Carrying +2
--
To view, visit http://gerrit.cloudera.org:8080/14792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
Gerrit-Change-Number: 14792
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 18:46:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Hello Anurag Mantripragada, Vihang Karajgaonkar, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14792
to look at the new patch set (#3).
Change subject: IMPALA-9188: Composite primary keys should use same constraint name
......................................................................
IMPALA-9188: Composite primary keys should use same constraint name
After IMPALA-9104, dataload started failing when USE_CDP_HIVE=true
because of HIVE-16603 (Enforce foreign keys to refer to primary keys or
unique keys), which is in Hive 3 but not Hive 2.
This patch fixes a bug from IMPALA-2112 where Impala was generating a
unique constraint name for each column in a composite primary key,
rather than using the same constraint name for each column.
Testing:
* Ran dataload + core tests with USE_CDP_HIVE=[true/false]
Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
---
M fe/src/main/java/org/apache/impala/analysis/TableDef.java
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/14792/3
--
To view, visit http://gerrit.cloudera.org:8080/14792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
Gerrit-Change-Number: 14792
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14792 )
Change subject: IMPALA-9188: Composite primary keys should use same constraint name
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14792/1/fe/src/main/java/org/apache/impala/analysis/TableDef.java
File fe/src/main/java/org/apache/impala/analysis/TableDef.java:
http://gerrit.cloudera.org:8080/#/c/14792/1/fe/src/main/java/org/apache/impala/analysis/TableDef.java@498
PS1, Line 498: constraintName
nit, adding a comment here would be useful
--
To view, visit http://gerrit.cloudera.org:8080/14792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
Gerrit-Change-Number: 14792
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 17:44:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14792 )
Change subject: IMPALA-9188: Composite primary keys should use same constraint name
......................................................................
IMPALA-9188: Composite primary keys should use same constraint name
After IMPALA-9104, dataload started failing when USE_CDP_HIVE=true
because of HIVE-16603 (Enforce foreign keys to refer to primary keys or
unique keys), which is in Hive 3 but not Hive 2.
This patch fixes a bug from IMPALA-2112 where Impala was generating a
unique constraint name for each column in a composite primary key,
rather than using the same constraint name for each column.
Testing:
* Ran dataload + core tests with USE_CDP_HIVE=[true/false]
Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
Reviewed-on: http://gerrit.cloudera.org:8080/14792
Reviewed-by: Sahil Takiar <st...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/TableDef.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Sahil Takiar: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
Gerrit-Change-Number: 14792
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14792 )
Change subject: IMPALA-9188: Composite primary keys should use same constraint name
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5132/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
Gerrit-Change-Number: 14792
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 18:44:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9188: Composite primary keys should use same constraint name
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14792 )
Change subject: IMPALA-9188: Composite primary keys should use same constraint name
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Carrying +2.
http://gerrit.cloudera.org:8080/#/c/14792/1/fe/src/main/java/org/apache/impala/analysis/TableDef.java
File fe/src/main/java/org/apache/impala/analysis/TableDef.java:
http://gerrit.cloudera.org:8080/#/c/14792/1/fe/src/main/java/org/apache/impala/analysis/TableDef.java@498
PS1, Line 498: ll primary key
> nit, adding a comment here would be useful
Done
--
To view, visit http://gerrit.cloudera.org:8080/14792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a91658945b0355753c3cf05be195757b37edaf4
Gerrit-Change-Number: 14792
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 17:56:10 +0000
Gerrit-HasComments: Yes