You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/24 23:07:31 UTC

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11206: [BEAM-9598] Ensuring _CustomBigQuerySource ValueProvider is only checked when strictly needed

TheNeuralBit commented on a change in pull request #11206: [BEAM-9598] Ensuring _CustomBigQuerySource ValueProvider is only checked when strictly needed
URL: https://github.com/apache/beam/pull/11206#discussion_r397515159
 
 

 ##########
 File path: sdks/python/apache_beam/io/gcp/bigquery.py
 ##########
 @@ -638,7 +638,6 @@ def __init__(
     self.kms_key = kms_key
     self.split_result = None
 
-  @check_accessible(['query'])
 
 Review comment:
   Isn't it correct to ensure that query is accessible, since it may be used in the call to `_start_query_job` below?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services