You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/06/20 21:52:19 UTC
Review Request 35699: Added an invariant CHECK_EQ for available
resources in HierarchicalAllocator::updateAllocation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35699/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp 646ee8c1c0fb824e1d17150b4e96e6281c65358f
Diff: https://reviews.apache.org/r/35699/diff/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 35699: Added an invariant CHECK_EQ for available
resources in HierarchicalAllocator::updateAllocation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35699/#review88684
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35699]
All tests passed.
- Mesos ReviewBot
On June 20, 2015, 7:52 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35699/
> -----------------------------------------------------------
>
> (Updated June 20, 2015, 7:52 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 646ee8c1c0fb824e1d17150b4e96e6281c65358f
>
> Diff: https://reviews.apache.org/r/35699/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35699: Added an invariant CHECK_EQ for available
resources in HierarchicalAllocator::updateAllocation.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35699/#review88836
-----------------------------------------------------------
Ship it!
Thanks for taking care of this!
- Ben Mahler
On June 20, 2015, 7:52 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35699/
> -----------------------------------------------------------
>
> (Updated June 20, 2015, 7:52 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 646ee8c1c0fb824e1d17150b4e96e6281c65358f
>
> Diff: https://reviews.apache.org/r/35699/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35699: Added an invariant CHECK_EQ for available
resources in HierarchicalAllocator::updateAllocation.
Posted by Michael Park <mc...@gmail.com>.
> On June 24, 2015, 12:44 a.m., Ben Mahler wrote:
> > src/master/allocator/mesos/hierarchical.hpp, lines 702-703
> > <https://reviews.apache.org/r/35699/diff/1/?file=988943#file988943line702>
> >
> > Whoops, Jie just noticed that this isn't correct because 'updatedAllocation' is for the framework only, whereas 'total' and 'available' are for all frameworks on the slave.
Yikes. Kudos to Jie for catching this. Sorry about that, I've followed-up on this at https://reviews.apache.org/r/35816/.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35699/#review89107
-----------------------------------------------------------
On June 20, 2015, 7:52 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35699/
> -----------------------------------------------------------
>
> (Updated June 20, 2015, 7:52 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 646ee8c1c0fb824e1d17150b4e96e6281c65358f
>
> Diff: https://reviews.apache.org/r/35699/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35699: Added an invariant CHECK_EQ for available
resources in HierarchicalAllocator::updateAllocation.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35699/#review89107
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.hpp (lines 702 - 703)
<https://reviews.apache.org/r/35699/#comment141704>
Whoops, Jie just noticed that this isn't correct because 'updatedAllocation' is for the framework only, whereas 'total' and 'available' are for all frameworks on the slave.
- Ben Mahler
On June 20, 2015, 7:52 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35699/
> -----------------------------------------------------------
>
> (Updated June 20, 2015, 7:52 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 646ee8c1c0fb824e1d17150b4e96e6281c65358f
>
> Diff: https://reviews.apache.org/r/35699/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>