You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/19 07:28:37 UTC
[GitHub] [spark] jiangxb1987 opened a new pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
jiangxb1987 opened a new pull request #28579:
URL: https://github.com/apache/spark/pull/28579
### What changes were proposed in this pull request?
The function `HistoryServerDiskManager`.`updateAccessTime()` would recompute the application store directory size every time it's triggered, this effort could be avoided because we already computed the new size outside the function call.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing test cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-632516801
Thanks, merged to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-632390622
**[Test build #122951 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122951/testReport)** for PR 28579 at commit [`f212f33`](https://github.com/apache/spark/commit/f212f33e9fe7f38e490f35f61e1e67fd466e5949).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-630641132
**[Test build #122840 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122840/testReport)** for PR 28579 at commit [`f212f33`](https://github.com/apache/spark/commit/f212f33e9fe7f38e490f35f61e1e67fd466e5949).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on a change in pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on a change in pull request #28579:
URL: https://github.com/apache/spark/pull/28579#discussion_r427086592
##########
File path: core/src/main/scala/org/apache/spark/deploy/history/HistoryServerDiskManager.scala
##########
@@ -238,10 +240,11 @@ private class HistoryServerDiskManager(
new File(appStoreDir, fileName)
}
- private def updateAccessTime(appId: String, attemptId: Option[String]): Unit = {
+ private def updateApplicationStoreInfo(
Review comment:
This function updates both the lastAccess time and the size, so it would be better to rename to `updateApplicationStoreInfo`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-631097518
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 closed pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
jiangxb1987 closed pull request #28579:
URL: https://github.com/apache/spark/pull/28579
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-632458377
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-632390622
**[Test build #122951 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122951/testReport)** for PR 28579 at commit [`f212f33`](https://github.com/apache/spark/commit/f212f33e9fe7f38e490f35f61e1e67fd466e5949).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-630734696
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-630641620
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-630962041
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-630734197
**[Test build #122840 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122840/testReport)** for PR 28579 at commit [`f212f33`](https://github.com/apache/spark/commit/f212f33e9fe7f38e490f35f61e1e67fd466e5949).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-632458377
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-632389963
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-630962041
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-632457408
**[Test build #122951 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122951/testReport)** for PR 28579 at commit [`f212f33`](https://github.com/apache/spark/commit/f212f33e9fe7f38e490f35f61e1e67fd466e5949).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-631097518
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-632391005
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-632391005
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-630961488
**[Test build #122853 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122853/testReport)** for PR 28579 at commit [`f212f33`](https://github.com/apache/spark/commit/f212f33e9fe7f38e490f35f61e1e67fd466e5949).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-630961488
**[Test build #122853 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122853/testReport)** for PR 28579 at commit [`f212f33`](https://github.com/apache/spark/commit/f212f33e9fe7f38e490f35f61e1e67fd466e5949).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-630641620
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-630734709
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122840/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-630734696
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-630641132
**[Test build #122840 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122840/testReport)** for PR 28579 at commit [`f212f33`](https://github.com/apache/spark/commit/f212f33e9fe7f38e490f35f61e1e67fd466e5949).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-630958421
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28579:
URL: https://github.com/apache/spark/pull/28579#issuecomment-631096636
**[Test build #122853 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122853/testReport)** for PR 28579 at commit [`f212f33`](https://github.com/apache/spark/commit/f212f33e9fe7f38e490f35f61e1e67fd466e5949).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org